Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tables] Remove attribute support from TableEntity #18442

Closed
annatisch opened this issue Apr 29, 2021 · 0 comments · Fixed by #18489
Closed

[Tables] Remove attribute support from TableEntity #18442

annatisch opened this issue Apr 29, 2021 · 0 comments · Fixed by #18489
Assignees
Labels
Milestone

Comments

@annatisch
Copy link
Member

As discussed in design reviews, we've asserted that the TableEntity object will only be used as an output, and unlikely to be imported by customers to use as input. It should therefore be updated accordingly:

  • Remove the _metadata key from inside the dictionary - this could conflict with a real entity property.
  • Make sure metadata is read-only.
  • Remove the custom attribute access from the object, so that properties within can only be accessed as dict key/values.
  • Update input type hints to just Mapping[str, PrimitiveTypes]
  • Look at whether we can insert TableEntity deserialization into the pipeline so as to avoid an extra dictionary construction (this is a perf consideration, and can come post-release).
@annatisch annatisch added this to the [2021] May milestone Apr 29, 2021
@annatisch annatisch changed the title [Tables] Removed attribute support from TableEntity [Tables] Remove attribute support from TableEntity Apr 29, 2021
@annatisch annatisch self-assigned this May 3, 2021
@annatisch annatisch linked a pull request May 5, 2021 that will close this issue
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant