Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tables] Use AzureTestCase instead of AzureMgmtTestCase #14352

Closed
seankane-msft opened this issue Oct 8, 2020 · 1 comment
Closed

[Tables] Use AzureTestCase instead of AzureMgmtTestCase #14352

seankane-msft opened this issue Oct 8, 2020 · 1 comment
Assignees
@seankane-msft
Labels
Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated Tables
Milestone
[2020] November

Comments

@seankane-msft
Copy link
Member

The test classes in testcase.py and asynctestcase.py inherit from the management plane test class.
@seankane-msft seankane-msft added Client This issue points to a problem in the data-plane of the library. Tables labels Oct 8, 2020
@seankane-msft seankane-msft added this to the [2020] November milestone Oct 8, 2020
@seankane-msft seankane-msft self-assigned this Oct 8, 2020
@seankane-msft seankane-msft added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Oct 8, 2020
@bradleydamato
Copy link
Contributor

Hi @seankane-msft ; it looks like a change only need to be made in testcase.py as asynctestcase.py imports TableTestCase from the former.

I've run the tox tests and here are the results:
image

Additionally, here is a PR: #14443

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@seankane-msft seankane-msft

Labels
Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated Tables
Projects
None yet
Milestone
[2020] November
Development

No branches or pull requests
2 participants
@bradleydamato @seankane-msft