From e8f3761ad0f294e12b1ba87c26c36fb62ccb2af8 Mon Sep 17 00:00:00 2001 From: Xiang Yan Date: Wed, 30 Oct 2024 12:27:46 -0700 Subject: [PATCH] Add test for get_arm_endpoints (#38196) --- .../azure-mgmt-core/azure/mgmt/core/tools.py | 3 +- .../tests/test_arm_endpoints.py | 44 +++++++++++++++++++ 2 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 sdk/core/azure-mgmt-core/tests/test_arm_endpoints.py diff --git a/sdk/core/azure-mgmt-core/azure/mgmt/core/tools.py b/sdk/core/azure-mgmt-core/azure/mgmt/core/tools.py index 2143a5e516ae..aee742fec070 100644 --- a/sdk/core/azure-mgmt-core/azure/mgmt/core/tools.py +++ b/sdk/core/azure-mgmt-core/azure/mgmt/core/tools.py @@ -47,6 +47,7 @@ "resource_id", "is_valid_resource_id", "is_valid_resource_name", + "get_arm_endpoints", ] @@ -230,7 +231,7 @@ def get_arm_endpoints(cloud_setting: AzureClouds) -> Dict[str, Any]: """ if cloud_setting == AzureClouds.AZURE_CHINA_CLOUD: return { - "resource_manager": "https://management.chinacloudapi.cn", + "resource_manager": "https://management.chinacloudapi.cn/", "credential_scopes": ["https://management.chinacloudapi.cn/.default"], } if cloud_setting == AzureClouds.AZURE_US_GOVERNMENT: diff --git a/sdk/core/azure-mgmt-core/tests/test_arm_endpoints.py b/sdk/core/azure-mgmt-core/tests/test_arm_endpoints.py new file mode 100644 index 000000000000..630b6d1be5bc --- /dev/null +++ b/sdk/core/azure-mgmt-core/tests/test_arm_endpoints.py @@ -0,0 +1,44 @@ +# -------------------------------------------------------------------------- +# +# Copyright (c) Microsoft Corporation. All rights reserved. +# +# The MIT License (MIT) +# +# Permission is hereby granted, free of charge, to any person obtaining a copy +# of this software and associated documentation files (the ""Software""), to deal +# in the Software without restriction, including without limitation the rights +# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +# copies of the Software, and to permit persons to whom the Software is +# furnished to do so, subject to the following conditions: +# +# The above copyright notice and this permission notice shall be included in +# all copies or substantial portions of the Software. +# +# THE SOFTWARE IS PROVIDED *AS IS*, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN +# THE SOFTWARE. +# +# -------------------------------------------------------------------------- +from azure.core import AzureClouds +from azure.mgmt.core.tools import get_arm_endpoints + + +def test_arm_endpoints(): + cloud_setting = AzureClouds.AZURE_PUBLIC_CLOUD + cloud_meta = get_arm_endpoints(cloud_setting) + assert cloud_meta["resource_manager"] == "https://management.azure.com/" + assert cloud_meta["credential_scopes"] == ["https://management.azure.com/.default"] + + cloud_setting = AzureClouds.AZURE_US_GOVERNMENT + cloud_meta = get_arm_endpoints(cloud_setting) + assert cloud_meta["resource_manager"] == "https://management.usgovcloudapi.net/" + assert cloud_meta["credential_scopes"] == ["https://management.core.usgovcloudapi.net/.default"] + + cloud_setting = AzureClouds.AZURE_CHINA_CLOUD + cloud_meta = get_arm_endpoints(cloud_setting) + assert cloud_meta["resource_manager"] == "https://management.chinacloudapi.cn/" + assert cloud_meta["credential_scopes"] == ["https://management.chinacloudapi.cn/.default"]