From 187523b3847a5e1f239bee7de216f623006b9622 Mon Sep 17 00:00:00 2001 From: Scott Beddall <45376673+scbedd@users.noreply.github.com> Date: Thu, 31 Oct 2024 13:21:41 -0700 Subject: [PATCH] clean up unused python script (#38128) --- scripts/devops_tasks/verify_change_log.py | 132 ---------------------- 1 file changed, 132 deletions(-) delete mode 100644 scripts/devops_tasks/verify_change_log.py diff --git a/scripts/devops_tasks/verify_change_log.py b/scripts/devops_tasks/verify_change_log.py deleted file mode 100644 index 505c3f0a9707..000000000000 --- a/scripts/devops_tasks/verify_change_log.py +++ /dev/null @@ -1,132 +0,0 @@ -#!/usr/bin/env python - -# -------------------------------------------------------------------------------------------- -# Copyright (c) Microsoft Corporation. All rights reserved. -# Licensed under the MIT License. See License.txt in the project root for license information. -# -------------------------------------------------------------------------------------------- - -# Normally, this module will be executed as referenced as part of the devops build definitions. -# An enterprising user can easily glance over this and leverage for their own purposes. - -import argparse -import sys -import os -import logging - -from common_tasks import run_check_call -from ci_tools.functions import discover_targeted_packages -from ci_tools.parsing import ParsedSetup - -logging.getLogger().setLevel(logging.INFO) - -root_dir = os.path.abspath(os.path.join(os.path.abspath(__file__), "..", "..", "..")) -psscript = os.path.join(root_dir, "scripts", "devops_tasks", "find_change_log.ps1") - -# Service fabric change log has non standard versioning for e.g 7.0.0.0 -# Verify change log should skip this package since this script looks for standard version format of x.y.z -NON_STANDARD_CHANGE_LOG_PACKAGES = ["azure-servicefabric",] - -def find_change_log(targeted_package, version): - # Execute powershell script to find a matching version in change log - command_array = ["pwsh"] - command_array.append("-File {}".format(psscript)) - command_array.append("-workingDir {}".format(targeted_package)) - command_array.append("-version {}".format(version)) - command_array.append("set-ExecutionPolicy Unrestricted") - - allowed_return_codes = [] - - # Execute powershell script to verify version - er_result = run_check_call( - command_array, root_dir, allowed_return_codes, True, False - ) - - if er_result: - logging.error( - "Failed to find version in change log for package {}".format( - targeted_package - ) - ) - return False - - return True - - -def verify_packages(targeted_packages): - # run the build and distribution - change_log_missing = {} - - for package in targeted_packages: - parsed_pkg = ParsedSetup.from_path(package) - - # Skip management packages and any explicitly excluded packages - if "-mgmt" in parsed_pkg.name or parsed_pkg.name in NON_STANDARD_CHANGE_LOG_PACKAGES: - logging.info("Skipping {} due to known exclusion in change log verification".format(parsed_pkg.name)) - continue - - if not find_change_log(package, parsed_pkg.version): - logging.error( - "Change log is not updated for package {0}, version {1}".format( - parsed_pkg.name, parsed_pkg.version - ) - ) - change_log_missing[parsed_pkg.name] = parsed_pkg.version - - return change_log_missing - - -if __name__ == "__main__": - parser = argparse.ArgumentParser( - description="Verifies latest version is updated in change log, Called from DevOps YAML Pipeline" - ) - - parser.add_argument( - "glob_string", - nargs="?", - help=( - "A comma separated list of glob strings that will target the top level directories that contain packages. " - 'Examples: All == "azure-*", Single = "azure-keyvault"' - ), - ) - - parser.add_argument( - "--service", - help=( - "Name of service directory (under sdk/) to build." - "Example: --service applicationinsights" - ), - ) - - parser.add_argument( - "--pkgfilter", - default="", - dest="package_filter_string", - help=( - "An additional string used to filter the set of artifacts by a simple CONTAINS clause." - ), - ) - - args = parser.parse_args() - - # We need to support both CI builds of everything and individual service - # folders. This logic allows us to do both. - if args.service: - service_dir = os.path.join("sdk", args.service) - target_dir = os.path.join(root_dir, service_dir) - else: - target_dir = root_dir - - # Skip nspkg and metapackage from version check. - # Change log file may be missing for these two types - # process glob helper methods filter nspkg and metapackages with filter type "Docs" - targeted_packages = discover_targeted_packages( - args.glob_string, target_dir, args.package_filter_string, "Docs" - ) - change_missing = verify_packages(targeted_packages) - if len(change_missing) > 0: - logging.error("Below packages do not have change log") - logging.error("***************************************************") - for pkg_name in change_missing.keys(): - logging.error("{0} - {1}".format(pkg_name, change_missing[pkg_name])) - - sys.exit(1)