From eae91ed6d3e5ff92333079a78e03c5d0c06e78f9 Mon Sep 17 00:00:00 2001 From: Neeraj Makam Date: Tue, 16 Jul 2019 16:11:53 -0700 Subject: [PATCH 1/2] Updating xmldoc - remarks on MessageHandlerOptions.MaxAutoRenewDuration to mention that there could be false-negative lockLost exceptions that could be raised --- .../Microsoft.Azure.ServiceBus/src/MessageHandlerOptions.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sdk/servicebus/Microsoft.Azure.ServiceBus/src/MessageHandlerOptions.cs b/sdk/servicebus/Microsoft.Azure.ServiceBus/src/MessageHandlerOptions.cs index 07e5ee08adae8..fe18edd993168 100644 --- a/sdk/servicebus/Microsoft.Azure.ServiceBus/src/MessageHandlerOptions.cs +++ b/sdk/servicebus/Microsoft.Azure.ServiceBus/src/MessageHandlerOptions.cs @@ -64,6 +64,8 @@ public int MaxConcurrentCalls /// Gets or sets the maximum duration within which the lock will be renewed automatically. This /// value should be greater than the longest message lock duration; for example, the LockDuration Property. /// The maximum duration during which locks are automatically renewed. + /// Messages can be renewed in the background inspite of explicity completing the message. + /// This could lead to false-negative MessageLockLostException being raised. public TimeSpan MaxAutoRenewDuration { get => this.maxAutoRenewDuration; From 5d02d1d92fa810b1b40ebdb47eff36e139bad51f Mon Sep 17 00:00:00 2001 From: Neeraj Makam Date: Tue, 16 Jul 2019 16:36:37 -0700 Subject: [PATCH 2/2] Updating the remark --- .../Microsoft.Azure.ServiceBus/src/MessageHandlerOptions.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/servicebus/Microsoft.Azure.ServiceBus/src/MessageHandlerOptions.cs b/sdk/servicebus/Microsoft.Azure.ServiceBus/src/MessageHandlerOptions.cs index fe18edd993168..00f1e2b854fdd 100644 --- a/sdk/servicebus/Microsoft.Azure.ServiceBus/src/MessageHandlerOptions.cs +++ b/sdk/servicebus/Microsoft.Azure.ServiceBus/src/MessageHandlerOptions.cs @@ -64,8 +64,8 @@ public int MaxConcurrentCalls /// Gets or sets the maximum duration within which the lock will be renewed automatically. This /// value should be greater than the longest message lock duration; for example, the LockDuration Property. /// The maximum duration during which locks are automatically renewed. - /// Messages can be renewed in the background inspite of explicity completing the message. - /// This could lead to false-negative MessageLockLostException being raised. + /// The message renew can continue for sometime in the background + /// after completion of message and result in a few false MessageLockLostExceptions temporarily. public TimeSpan MaxAutoRenewDuration { get => this.maxAutoRenewDuration;