Regenerate clients for ManagedInstanceProxyOverride #5971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsgouda
suggested changes
Apr 26, 2019
src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj
Show resolved
Hide resolved
|
@jamestao Please link the REST spec PR |
|
specs PR: Azure/azure-rest-api-specs#5780 |
|
Can you in some way reference the enum class from unit tests so that build breaks if it's accidentally removed again? |
jaredmoo
approved these changes
Apr 26, 2019
johnpaulkee
reviewed
Apr 26, 2019
| @@ -38,7 +38,7 @@ public void TestCreateUpdateGetDropManagedInstance() | |||
| string location = "westcentralus"; | |||
|
|
|||
| bool publicDataEndpointEnabled = true; | |||
| string proxyOverride = "Proxy"; | |||
| string proxyOverride = ManagedInstanceProxyOverride.Proxy; | |||
There was a problem hiding this comment.
this should help us catch this next time.
johnpaulkee
approved these changes
Apr 26, 2019
| @@ -38,7 +38,7 @@ public void TestCreateUpdateGetDropManagedInstance() | |||
| string location = "westcentralus"; | |||
|
|
|||
| bool publicDataEndpointEnabled = true; | |||
| string proxyOverride = "Proxy"; | |||
| string proxyOverride = ManagedInstanceProxyOverride.Proxy; | |||
There was a problem hiding this comment.
this should help us catch this next time.
mentat9
pushed a commit
to mentat9/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2019
* Regenerate clients for ManagedInstanceProxyOverride * Update test to reference enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.