From 512e78bd2d55745aac518524312729590c73987d Mon Sep 17 00:00:00 2001 From: Darren Cohen <39422044+dargilco@users.noreply.github.com> Date: Mon, 12 Feb 2024 12:03:38 -0800 Subject: [PATCH 1/2] Minor README.md & source code comment fixes --- sdk/openai/Azure.AI.OpenAI/README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/openai/Azure.AI.OpenAI/README.md b/sdk/openai/Azure.AI.OpenAI/README.md index 3a490c79f7b06..f45f2507d08f0 100644 --- a/sdk/openai/Azure.AI.OpenAI/README.md +++ b/sdk/openai/Azure.AI.OpenAI/README.md @@ -76,9 +76,9 @@ OpenAIClient client = useAzureOpenAI : new OpenAIClient("your-api-key-from-platform.openai.com"); ``` -#### Create OpenAIClient with an Azure Active Directory Credential +#### Create OpenAIClient with a Microsoft Entra ID Credential -Client subscription key authentication is used in most of the examples in this getting started guide, but you can also authenticate with Azure Active Directory using the [Azure Identity library][azure_identity]. To use the [DefaultAzureCredential][azure_identity_dac] provider shown below, +Client subscription key authentication is used in most of the examples in this getting started guide, but you can also authenticate with Microsoft Entra ID (formerly Azure Active Directory) using the [Azure Identity library][azure_identity]. To use the [DefaultAzureCredential][azure_identity_dac] provider shown below, or other credential providers provided with the Azure SDK, please install the Azure.Identity package: ```dotnetcli @@ -380,7 +380,7 @@ Additionally: if you would like to control the behavior of tool calls, you can u - Providing a reference to a named function definition or function tool definition, as below, will instruct the model to restrict its response to calling the corresponding tool. When calling tools in this configuration, response `ChatChoice` instances will report a `FinishReason` of `CompletionsFinishReason.Stopped` and the corresponding - `ToolCalls` property will be populated Note that, because the model was constrained to a specific tool, it does + `ToolCalls` property will be populated. Note that, because the model was constrained to a specific tool, it does **NOT** report the same `CompletionsFinishReason` value of `ToolCalls` expected when using `ChatCompletionsToolChoice.Auto`. From 442c95cdc43084e993792b92c921ee9231723ed3 Mon Sep 17 00:00:00 2001 From: Darren Cohen <39422044+dargilco@users.noreply.github.com> Date: Mon, 12 Feb 2024 12:04:47 -0800 Subject: [PATCH 2/2] Typo fix in azure.core --- sdk/core/Azure.Core/src/ClientOptions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/core/Azure.Core/src/ClientOptions.cs b/sdk/core/Azure.Core/src/ClientOptions.cs index 25beb96f1a9e9..2832dd0e13ac1 100644 --- a/sdk/core/Azure.Core/src/ClientOptions.cs +++ b/sdk/core/Azure.Core/src/ClientOptions.cs @@ -36,7 +36,7 @@ protected ClientOptions(): this(Default, null) } /// - /// Creates a new instance of with the specificed . + /// Creates a new instance of with the specified . /// /// to be used for . protected ClientOptions(DiagnosticsOptions? diagnostics)