Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Translation Text client library #34965

Merged
merged 51 commits into from
Apr 6, 2023
Merged

Add Translation Text client library #34965

merged 51 commits into from
Apr 6, 2023

Conversation

MikeyMCZ
Copy link
Member

Michal Materna and others added 30 commits February 22, 2023 10:02
Removing Detect
* Initial work for adding tests

* Sanitizing the keys

* Covering all test scenarios from Sample document and Hero scenarios

* Updating dynamic dictionary test case

* Updated based on PR comments

---------

Co-authored-by: Hamshavathi Munibyraiah (Murphy V-hmunibyrai Associates Inc) <[email protected]>
@pallavit pallavit requested a review from joseharriaga March 28, 2023 16:36
@joseharriaga joseharriaga merged commit fdfe85d into Azure:main Apr 6, 2023
@lirenhe
Copy link
Member

lirenhe commented Apr 11, 2023

cc @Azure/dpg-devs

/// <param name="context"> The request context, which can override default behaviors of the client pipeline on a per-call basis. </param>
/// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception>
/// <returns> The response returned from the service. Details of the response body schema are in the Remarks section below. </returns>
internal virtual async Task<Response> GetLanguagesAsync(string clientTraceId = null, string scope = null, string acceptLanguage = null, ETag? ifNoneMatch = null, RequestContext context = null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeyMCZ Do you want to make the protocol method internal here? If so, you should mark the operation with decorator @protocol(false) like this Azure/azure-rest-api-specs#23681

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @lmazuel @m-nash

Instead of adding the customized operation, seems it is better to update the typespec to add the decorator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants