From eb0ec9fab3a9ba86936e283cc61311c5553ca051 Mon Sep 17 00:00:00 2001 From: Scott Schaab Date: Thu, 13 Oct 2022 09:23:34 -0700 Subject: [PATCH 1/3] [Identity] Hide dev credential timeout API for 1.8.0 release --- sdk/identity/Azure.Identity/CHANGELOG.md | 7 +------ .../src/Credentials/AzureCliCredentialOptions.cs | 2 +- .../src/Credentials/AzurePowerShellCredentialOptions.cs | 2 +- .../src/Credentials/DefaultAzureCredentialOptions.cs | 2 +- .../src/Credentials/VisualStudioCredentialOptions.cs | 2 +- 5 files changed, 5 insertions(+), 10 deletions(-) diff --git a/sdk/identity/Azure.Identity/CHANGELOG.md b/sdk/identity/Azure.Identity/CHANGELOG.md index 8746c78a3a788..88e4dc3b412d7 100644 --- a/sdk/identity/Azure.Identity/CHANGELOG.md +++ b/sdk/identity/Azure.Identity/CHANGELOG.md @@ -1,13 +1,8 @@ # Release History -## 1.8.0-beta.1 (Unreleased) +## 1.8.0-beta.1 (2022-10-13) ### Features Added -- Credentials that are implemented via launching a sub-process to acquire tokens now have configurable timeouts. This addresses scenarios where these proceses can take longer than the current default timeout values. (A community contribution, courtesy of _[reynaldoburgos](https://github.com/reynaldoburgos)_). The affected credentials and their associated options are: - - `AzureCliCredential` and `AzureCliCredentialOptions.CliProcessTimeout` - - `AzurePowerShellCredential` and `AzurePowerShellCredentialOptions.PowerShellProcessTimeout` - - `VisualStudioCredential` and `VisualStudioCredentialOptions.VisualStudioProcessTimeout` - - `DefaultAzureCredential` and `DefaultAzureCredentialOptions.DeveloperCredentialTimeout` Note: this option applies to all developer credentials above when using `DefaultAzureCredential`. - Reintroduced `ManagedIdentityCredential` token caching support from 1.7.0-beta.1 - `EnvironmentCredential` updated to support specifying a certificate password via the `AZURE_CLIENT_CERTIFICATE_PASSWORD` environment variable diff --git a/sdk/identity/Azure.Identity/src/Credentials/AzureCliCredentialOptions.cs b/sdk/identity/Azure.Identity/src/Credentials/AzureCliCredentialOptions.cs index df5f3cb041d10..7f5e4445d16c4 100644 --- a/sdk/identity/Azure.Identity/src/Credentials/AzureCliCredentialOptions.cs +++ b/sdk/identity/Azure.Identity/src/Credentials/AzureCliCredentialOptions.cs @@ -26,6 +26,6 @@ public class AzureCliCredentialOptions : TokenCredentialOptions /// /// The Cli process timeout. /// - public TimeSpan? CliProcessTimeout { get; set; } + internal TimeSpan? CliProcessTimeout { get; set; } } } diff --git a/sdk/identity/Azure.Identity/src/Credentials/AzurePowerShellCredentialOptions.cs b/sdk/identity/Azure.Identity/src/Credentials/AzurePowerShellCredentialOptions.cs index 2c4b8b2b6e580..82ccfa21cdfd1 100644 --- a/sdk/identity/Azure.Identity/src/Credentials/AzurePowerShellCredentialOptions.cs +++ b/sdk/identity/Azure.Identity/src/Credentials/AzurePowerShellCredentialOptions.cs @@ -26,6 +26,6 @@ public class AzurePowerShellCredentialOptions : TokenCredentialOptions /// /// The Powershell process timeout. /// - public TimeSpan? PowerShellProcessTimeout { get; set; } = TimeSpan.FromSeconds(10); + internal TimeSpan? PowerShellProcessTimeout { get; set; } = TimeSpan.FromSeconds(10); } } diff --git a/sdk/identity/Azure.Identity/src/Credentials/DefaultAzureCredentialOptions.cs b/sdk/identity/Azure.Identity/src/Credentials/DefaultAzureCredentialOptions.cs index 2c19120088d79..21bd8a27f7262 100644 --- a/sdk/identity/Azure.Identity/src/Credentials/DefaultAzureCredentialOptions.cs +++ b/sdk/identity/Azure.Identity/src/Credentials/DefaultAzureCredentialOptions.cs @@ -198,7 +198,7 @@ public string VisualStudioCodeTenantId /// /// Specifies timeout for Developer credentials. e.g. Visual Studio, Azure CLI, Azure Powershell. /// - public TimeSpan? DeveloperCredentialTimeout { get; set; } = TimeSpan.FromSeconds(30); + internal TimeSpan? DeveloperCredentialTimeout { get; set; } = TimeSpan.FromSeconds(30); /// /// Specifies whether the will be excluded from the authentication flow. Setting to true disables reading diff --git a/sdk/identity/Azure.Identity/src/Credentials/VisualStudioCredentialOptions.cs b/sdk/identity/Azure.Identity/src/Credentials/VisualStudioCredentialOptions.cs index 204eab0f35c79..854797fc8bffa 100644 --- a/sdk/identity/Azure.Identity/src/Credentials/VisualStudioCredentialOptions.cs +++ b/sdk/identity/Azure.Identity/src/Credentials/VisualStudioCredentialOptions.cs @@ -32,6 +32,6 @@ public string TenantId /// /// The VisualStudio process timeout. /// - public TimeSpan? VisualStudioProcessTimeout { get; set; } + internal TimeSpan? VisualStudioProcessTimeout { get; set; } } } From db17cc7e410f7e559e9adc7553900307f645d9b9 Mon Sep 17 00:00:00 2001 From: Scott Schaab Date: Thu, 13 Oct 2022 09:36:27 -0700 Subject: [PATCH 2/3] update API spec --- .../Azure.Identity/api/Azure.Identity.netstandard2.0.cs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs b/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs index 7d1ab7ce1b2d6..670591ffdc8ad 100644 --- a/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs +++ b/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs @@ -60,7 +60,6 @@ public partial class AzureCliCredentialOptions : Azure.Identity.TokenCredentialO { public AzureCliCredentialOptions() { } public System.Collections.Generic.IList AdditionallyAllowedTenants { get { throw null; } } - public System.TimeSpan? CliProcessTimeout { get { throw null; } set { } } public string TenantId { get { throw null; } set { } } } public partial class AzurePowerShellCredential : Azure.Core.TokenCredential @@ -74,7 +73,6 @@ public partial class AzurePowerShellCredentialOptions : Azure.Identity.TokenCred { public AzurePowerShellCredentialOptions() { } public System.Collections.Generic.IList AdditionallyAllowedTenants { get { throw null; } } - public System.TimeSpan? PowerShellProcessTimeout { get { throw null; } set { } } public string TenantId { get { throw null; } set { } } } public partial class ChainedTokenCredential : Azure.Core.TokenCredential @@ -149,7 +147,6 @@ public partial class DefaultAzureCredentialOptions : Azure.Identity.TokenCredent { public DefaultAzureCredentialOptions() { } public System.Collections.Generic.IList AdditionallyAllowedTenants { get { throw null; } } - public System.TimeSpan? DeveloperCredentialTimeout { get { throw null; } set { } } public bool ExcludeAzureCliCredential { get { throw null; } set { } } public bool ExcludeAzurePowerShellCredential { get { throw null; } set { } } public bool ExcludeEnvironmentCredential { get { throw null; } set { } } @@ -381,6 +378,5 @@ public partial class VisualStudioCredentialOptions : Azure.Identity.TokenCredent public VisualStudioCredentialOptions() { } public System.Collections.Generic.IList AdditionallyAllowedTenants { get { throw null; } } public string TenantId { get { throw null; } set { } } - public System.TimeSpan? VisualStudioProcessTimeout { get { throw null; } set { } } } } From 73ae5dcdeed45ebc13e5692f75c4eb6d0e0cec00 Mon Sep 17 00:00:00 2001 From: Scott Schaab Date: Thu, 13 Oct 2022 09:56:59 -0700 Subject: [PATCH 3/3] update changelog for release --- sdk/identity/Azure.Identity/CHANGELOG.md | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sdk/identity/Azure.Identity/CHANGELOG.md b/sdk/identity/Azure.Identity/CHANGELOG.md index 88e4dc3b412d7..eec27cd8bf042 100644 --- a/sdk/identity/Azure.Identity/CHANGELOG.md +++ b/sdk/identity/Azure.Identity/CHANGELOG.md @@ -9,16 +9,6 @@ ### Breaking Changes - Excluded `VisualStudioCodeCredential` from `DefaultAzureCredential` token chain by default as SDK authentication via Visual Studio Code is broken due to issue [#27263](https://github.com/Azure/azure-sdk-for-net/issues/27263). The `VisualStudioCodeCredential` will be re-enabled in the `DefaultAzureCredential` flow once a fix is in place. Issue [#30525](https://github.com/Azure/azure-sdk-for-net/issues/30525) tracks this. In the meantime Visual Studio Code users can authenticate their development environment using the [Azure CLI](https://learn.microsoft.com/cli/azure/). -### Bugs Fixed - -### Other Changes - -### Acknowledgments - -Thank you to our developer community members who helped to make Azure Identity better with their contributions to this release: - -- _[reynaldoburgos](https://github.com/reynaldoburgos)_ - ## 1.7.0 (2022-09-19) ### Features Added