-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync eng/common directory with azure-sdk-tools for PR 1031 #15284
Conversation
db18be3
to
db50a01
Compare
Closing; superseded by #15284 |
Hello @jsquire! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
/check-enforcer override |
@jsquire thanks for reviewing and merging but these sync PR's are supposed to follow the new workflow defined at https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow and the tools PR owner should be the one merging them. Merging them earlier causes some issues with our syncing and also doesn't allow the tools owner to finish their testing before merging the common changes. |
Apologies for overstepping. My understanding was that testing and review were done on merging into the central repo and that these syncs were just mechanical. I'll avoid taking direct action going forward. Can we change to the new |
Thanks for the feedback @jsquire we are definitely planning to do that. I know @chidozieononiwu is working on adding PR owners support so that we can use it for these automated PRs. @chidozieononiwu we should also add the new |
Containerregistry maps datamigration t1 del (Azure#15284) * sql t2 readme config * readme config * Update readme.python.md * conflient resolve * t1 del Co-authored-by: msyyc <[email protected]>
Containerregistry maps datamigration t1 del (Azure#15284) * sql t2 readme config * readme config * Update readme.python.md * conflient resolve * t1 del Co-authored-by: msyyc <[email protected]>
Containerregistry maps datamigration t1 del (Azure#15284) * sql t2 readme config * readme config * Update readme.python.md * conflient resolve * t1 del Co-authored-by: msyyc <[email protected]>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1031
See eng/common workflow