Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync eng/common directory with azure-sdk-tools for PR 1031 #15284

Merged
1 commit merged into from
Sep 24, 2020

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1031
See eng/common workflow

@azure-sdk azure-sdk added the EngSys This issue is impacting the engineering system. label Sep 21, 2020
@jsquire jsquire added Central-EngSys This issue is owned by the Engineering System team. and removed EngSys This issue is impacting the engineering system. labels Sep 23, 2020
@azure-sdk azure-sdk force-pushed the sync-eng/common-vcpkg-support-1031 branch from db18be3 to db50a01 Compare September 23, 2020 20:18
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. and removed Central-EngSys This issue is owned by the Engineering System team. labels Sep 23, 2020
@jsquire
Copy link
Member

jsquire commented Sep 24, 2020

Closing; superseded by #15284

@jsquire jsquire closed this Sep 24, 2020
@jsquire jsquire reopened this Sep 24, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

Hello @jsquire!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@jsquire
Copy link
Member

jsquire commented Sep 24, 2020

/check-enforcer override

@ghost ghost merged commit 6e2b013 into Azure:master Sep 24, 2020
@weshaggard
Copy link
Member

@jsquire thanks for reviewing and merging but these sync PR's are supposed to follow the new workflow defined at https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow and the tools PR owner should be the one merging them. Merging them earlier causes some issues with our syncing and also doesn't allow the tools owner to finish their testing before merging the common changes.

@jsquire
Copy link
Member

jsquire commented Sep 24, 2020

Apologies for overstepping. My understanding was that testing and review were done on merging into the central repo and that these syncs were just mechanical. I'll avoid taking direct action going forward.

Can we change to the new Central-EngSys tag and assign the PR owner when this is generated? We're trying to improve on the number of PRs that stall in the repository, many of which seem to be the automated increment or these sync items. Having a clear line of ownership would be helpful in identifying the correct person to ping for information.

@weshaggard
Copy link
Member

Thanks for the feedback @jsquire we are definitely planning to do that. I know @chidozieononiwu is working on adding PR owners support so that we can use it for these automated PRs. @chidozieononiwu we should also add the new Central-EngSys label to these PRs.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Jul 21, 2021
Containerregistry maps datamigration t1 del (Azure#15284)

* sql t2 readme config

* readme config

* Update readme.python.md

* conflient resolve

* t1 del

Co-authored-by: msyyc <[email protected]>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Jul 21, 2021
Containerregistry maps datamigration t1 del (Azure#15284)

* sql t2 readme config

* readme config

* Update readme.python.md

* conflient resolve

* t1 del

Co-authored-by: msyyc <[email protected]>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Jul 21, 2021
Containerregistry maps datamigration t1 del (Azure#15284)

* sql t2 readme config

* readme config

* Update readme.python.md

* conflient resolve

* t1 del

Co-authored-by: msyyc <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants