Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PowerShell Core fails to load Azure.Core because of version dependency #8739

Closed
3 tasks
erich-wang opened this issue Nov 12, 2019 · 2 comments
Closed
3 tasks
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@erich-wang
Copy link
Member

erich-wang commented Nov 12, 2019

Describe the bug
Azure.Core should depend on System.Diagnostics.DiagnosticSource nuget package 4.5.1 instead of 4.6 to make it work in PowerShell Core.

PowerShell Core 6.2.2 (released this July) has dependency on version 4.0.3.1 of System.Diagnostics.DiagnosticSource, however Azure.Core depends on higher version 4.0.4.0. PowerShell Core will automatically load 4.0.3.1 of System.Diagnostics.DiagnosticSource when starting, later when loading modules depending on Azure.Core, PowerShell Core will report failure because it need higher version 4.0.4.0 of System.Diagnostics.DiagnosticSource.

Exception or Stack Trace
Add the exception log and stack trace if available

To Reproduce
Steps to reproduce the behavior:

Code Snippet
Add the code snippet that causes the issue.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Setup (please complete the following information):

  • OS: [e.g. iOS]
  • IDE : [e.g. IntelliJ]
  • Version of the Library used

Additional context
Add any other context about the problem here.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Bug Description Added
  • Repro Steps Added
  • Setup information Added
@triage-new-issues triage-new-issues bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 12, 2019
@AlexGhiondea AlexGhiondea added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Nov 12, 2019
@triage-new-issues triage-new-issues bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 12, 2019
@pakrym
Copy link
Contributor

pakrym commented Nov 12, 2019

Downgrading the dependency is a breaking change and we need 4.6 to function properly.

This would be fixed by PowerShell core 7 shipping with updated dependencies: https://github.com/PowerShell/PowerShell/releases/tag/v7.0.0-preview.5

@pakrym pakrym closed this as completed Nov 12, 2019
@pakrym
Copy link
Contributor

pakrym commented Nov 12, 2019

There is also System.Runtime.CompilerServices.Unsafe pinned by powershell that Azure libraries use it can't not be lowered or removed because we use system.text.json for serialization.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

3 participants