Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Bus RBAC: Revisit Naming and Discoverability of Public API Changes #6548

Closed
jsquire opened this issue Jun 12, 2019 · 1 comment
Closed
Assignees
Labels
breaking-change Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@jsquire
Copy link
Member

jsquire commented Jun 12, 2019

Summary

The recent set of changes to the Service Bus client library made for the RBAC feature made a set of changes to the API surface, garnering some feedback with respect to its discoverability and naming. Due to sensitivity around timing, the changes were merged to facilitate internal testing of the feature. Before public release, another review pass for naming would be helpful to ensure a good user experience for the API.

Scope of Work

  • Revisit feedback from the RBAC pull request (ServiceBus SDK: Rbac support #6393) and continue discussion and evaluation of the feedback.

  • As an outcome of review and discussion, adopt or defer/decline feedback around the API surface, naming, types, and other constructs.

  • Refactor, as needed, to incorporate the agreed upon set of changes.

Out of Scope

  • Large changes to implementation that would alter the tested feature set or functionality.

  • A full review of the API surface; the discussion will be scoped to the changes made for RBAC in order to limit the impact on existing consumers.

Success Criteria

  • Feedback on the API naming and discoverability has been vetted and explicitly accepted, deferred, or declined.

  • Accepted changes have been made and submitted via pull request.

References

@jsquire jsquire added Service Bus Client This issue points to a problem in the data-plane of the library. breaking-change labels Jun 12, 2019
@bainian12345
Copy link
Contributor

Please see this PR for addressing this issue.

@jsquire jsquire closed this as completed Jun 13, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

No branches or pull requests

2 participants