Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] SSE: Analysis and design #42284

Closed
jsquire opened this issue Feb 29, 2024 · 6 comments
Closed

[Core] SSE: Analysis and design #42284

jsquire opened this issue Feb 29, 2024 · 6 comments
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Milestone

Comments

@jsquire
Copy link
Member

jsquire commented Feb 29, 2024

Overview

You down with SSE? Well, Krzysztof is - so we should go ask him what we need and get his thoughts on a design.

Scope of work

  • Capture requirements from Krzysztof, covering OpenAI and the general form.
  • Determine whether this feature lands in Core or ClientModel after discussing with Krzysztof and Anne.
  • Determine code generation needs for this feature after discussing with Michael.
  • Create issue(s) to describe the needed implementation scope and the design for both code gen and client library work.

Out of scope

  • The implementation; that will be covered by a separate issue

Success criteria

  • The requirements for SSE are understood and captured in an issue.
  • A high-level design for SSE was created and details are captured in an issue.
  • Work to implement client library scope is understood and captured in an issue.
  • Work to implement code generation scope is understood and captured in an issue.
  • Estimation to complete implementation, end-to-end, is known
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Feb 29, 2024
@jsquire jsquire added this to the Backlog milestone Feb 29, 2024
@annelo-msft annelo-msft modified the milestones: Backlog, 2024-04 Mar 12, 2024
@annelo-msft annelo-msft added the System.ClientModel Base Core library label Mar 12, 2024
@pallavit
Copy link
Contributor

What does runtime feature mean? BTW I love the project grooming @annelo-msft

@annelo-msft
Copy link
Member

What does runtime feature mean?

That is @jsquire's categorization - I didn't change anything he'd already categorized. @jsquire can you unpack this one for us?

@jsquire
Copy link
Member Author

jsquire commented Mar 13, 2024

can you unpack this one for us?

OpenAI has a built-in SSE implementation. We know that we want to move this to ClientModel at some point in the future so that other libraries can also make use. We do not yet understand the scope of what is needed. This issue is about gathering the requirements from our SME (Krzysztof) and capturing the work in issues.

@jsquire
Copy link
Member Author

jsquire commented Mar 13, 2024

What does runtime feature mean?

Not a clue. I just know that it wasn't a "partner ask" and this is the only other value. The choices predate me, and I'd like to see the field die because I don't think it offers any value in its current form.

@annelo-msft
Copy link
Member

Related to #43032

@joseharriaga FYI

@annelo-msft
Copy link
Member

Closed by #43840, modulo SCM GA-release activities.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. System.ClientModel Base Core library
Projects
None yet
Development

No branches or pull requests

3 participants