Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create parallel Synthesized types that mirror Parameter, Output, Infrastructure, and Resource #42035

Closed
JoshLove-msft opened this issue Feb 16, 2024 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Provisioning

Comments

@JoshLove-msft
Copy link
Member

          Would `SynthesizedModuleScope` be more clear that this is not an intrinsic property of the resource?

Did you consider a SynthesizedResource which takes a resource and has this property on it?

Originally posted by @m-nash in #42029 (comment)

@JoshLove-msft JoshLove-msft added Client This issue points to a problem in the data-plane of the library. Provisioning labels Feb 16, 2024
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 16, 2024
@JoshLove-msft JoshLove-msft changed the title Create parallel Synthesized types that mirror Parameter, Output, and Resource Create parallel Synthesized types that mirror Parameter, Output, Infrastructure, and Resource Feb 16, 2024
@jsquire jsquire removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 16, 2024
@JoshLove-msft
Copy link
Member Author

I don't think the Output and Parameter mirrored types are necessary, as we can avoid mutating Parameter by introducing new internal ctor. Adding a separate type would force us to make Parameter a class so we could polymorph over the Parameter in the internal ParameterOverrides dictionary in Resource, or we'd need a separate dictionary holding the ModuleParameter instances. Similarly, for output we can just construct a new Output instance without mutating the original instance.

@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Provisioning
Projects
None yet
Development

No branches or pull requests

2 participants