Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Add example of auth with TokenCredentials to Azure.Storage.Files.Shares samples #40148

Closed
ArturAdam opened this issue Nov 21, 2023 · 4 comments · Fixed by #46759
Closed

[FEATURE REQ] Add example of auth with TokenCredentials to Azure.Storage.Files.Shares samples #40148

ArturAdam opened this issue Nov 21, 2023 · 4 comments · Fixed by #46759
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)

Comments

@ArturAdam
Copy link

Library name

Azure.Storage.Files.Shares

Please describe the feature.

I would like to request an update to the existing documentation and code samples related to Azure Storage File Shares. Recently, OAuth support was added for Azure file shares as detailed in the Microsoft documentation (https://learn.microsoft.com/en-us/azure/storage/files/authorize-oauth-rest?tabs=portal). However, the existing samples and documentation primarily showcase authentication methods that predate this addition.
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-triage Workflow: This issue needs the team to triage. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files) labels Nov 21, 2023
This was referenced Nov 21, 2023
Closed
Closed
@jsquire
Copy link
Member

jsquire commented Nov 21, 2023

This issue has been transferred to the repository where the linked article is maintained, so that the content authors are made aware. Please see #117313.

@jsquire jsquire closed this as completed Nov 21, 2023
@ArturAdam
Copy link
Author

@jsquire I meant samples in this repo here: https://github.com/Azure/azure-sdk-for-net/tree/c4f2dda276227af505ebabeabe233737b483e583/sdk/storage/Azure.Storage.Files.Shares/samples

@jsquire
Copy link
Member

jsquire commented Nov 22, 2023

@ArturAdam: Thanks for the clarification. We'll route this over to the folks that own the Storage library for consideration.

@jsquire jsquire reopened this Nov 22, 2023
@jsquire jsquire added Service Attention Workflow: This issue is responsible by Azure service team. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team and removed needs-team-triage Workflow: This issue needs the team to triage. labels Nov 22, 2023
@github-actions GitHub Actions
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

@nickliu-msft nickliu-msft mentioned this issue Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
2 participants
@jsquire @ArturAdam