Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Activity Extensions class from Azure.Core shared source #37593

Closed
6 tasks done
m-redding opened this issue Jul 13, 2023 · 0 comments
Closed
6 tasks done

Remove Activity Extensions class from Azure.Core shared source #37593

m-redding opened this issue Jul 13, 2023 · 0 comments
Assignees
@m-redding
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@m-redding
Copy link
Member

m-redding commented Jul 13, 2023 •
edited
Loading

Library name

Azure.Core

Please describe the feature.

After upgrading System.Diagnostics.DiagnosticSource to 6.0.1, we need to remove all previous references to the types in this version via reflection and replace them with direct references.

The following libraries use the Activity Extensions class:

  • Azure.Messaging.EventGrid
  • Azure.Storage.Common (tests)
  • Azure.Messaging.EventHubs
  • Azure.Messaging.ServiceBus
  • Azure.Storage.DataMovement

Autorest repo:

  • Make sure all references there are fixed as well. There are no references to this class in the autorest repo

Once all this is done, then the ActivityExtensions class in DiagnosticScope.cs can be removed. Doing this in phases to avoid build errors and make things clearer.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@m-redding m-redding

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m-redding