Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure OpenAI] Add model factory parity for chat completions #37127

Open
trrwilson opened this issue Jun 20, 2023 · 0 comments
Open

[Azure OpenAI] Add model factory parity for chat completions #37127

trrwilson opened this issue Jun 20, 2023 · 0 comments
Labels
Client This issue points to a problem in the data-plane of the library. OpenAI

Comments

@trrwilson
Copy link
Member

Library name

Azure.AI.OpenAI

Please describe the feature.

The code-generated AzureOpenAIModelFactory includes methods for Embeddings and non-Chat completions, yet conspicuously lacks support for Chat Completions. The underlying reason for code generation not emitting these automatically should be explored, but in parallel:

  • We should implement (manually or not) model factory parity for all public methods (notably absent now: chat)
  • We should implement test coverage for the model factory
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 20, 2023
@joseharriaga joseharriaga added OpenAI Client This issue points to a problem in the data-plane of the library. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 21, 2023
@ralph-msft ralph-msft mentioned this issue Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. OpenAI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add chat completions model factory methods ralph-msft/azure-sdk-for-net
2 participants
@trrwilson @joseharriaga