Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] TypeSpec DPG onboarding document improvement #35235

Open
raych1 opened this issue Mar 30, 2023 · 3 comments
Open

[Issue] TypeSpec DPG onboarding document improvement #35235

raych1 opened this issue Mar 30, 2023 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Docs DPG

Comments

@raych1
Copy link
Member

raych1 commented Mar 30, 2023

Information

I follow the onboarding document and these are some gaps to fill.

  1. AzureSDKGeneration_Prerequistites.md
    Prerequisite of installation part: should select azure development workload when install vs2022.

  2. AzureSDKPackage_Setup.md
    Step of creating sdk package, currently dotnet sdk 7 doesn't work. The workaround is to use dotnet sdk 6. The step needs to mention dotnet version in global.json should be updated to 6.x.

  3. AzureSDKCodeGeneration_DataPlane_QuickStart
    Below error is reported when run dotnet build /t:GenerateCode.

Copy-Item: /home/raychen/repos/github/raych1/azure-sdk-for-net/eng/common/scripts/TypeSpec-Project-Sync.ps1:23:5
  Line |
    23 |      Copy-Item -Path $source -Destination $dest -Recurse -Force
       |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       | Cannot find path
       | '/home/raychen/repos/github/raych1/sparse-spec/Azure.AI.AnomalyDetector/home/raychen/repos/github/azure-rest-api-specs/specification/cognitiveservices/AnomalyDetector' because it does not exist.

/home/raychen/.nuget/packages/microsoft.azure.autorest.csharp/3.0.0-beta.20230326.1/buildMultiTargeting/Microsoft.Azure.AutoRest.CSharp.targets(55,5): error MSB3073: The command "pwsh -NoProfile -NonInteractive -executionpolicy Unrestricted -File /home/raychen/repos/github/raych1/azure-sdk-for-net/sdk/anomalyDetector/Azure.AI.AnomalyDetector/src/../../../../eng/common/scripts/TypeSpec-Project-Sync.ps1 /home/raychen/repos/github/raych1/azure-sdk-for-net/sdk/anomalyDetector/Azure.AI.AnomalyDetector/src/.." exited with code 1. [/home/raychen/repos/github/raych1/azure-sdk-for-net/sdk/anomalyDetector/Azure.AI.AnomalyDetector/src/Azure.AI.AnomalyDetector.csproj]
@raych1 raych1 added Docs MQ This issue is part of a "milestone of quality" initiative. DPG labels Mar 30, 2023
@chunyu3
Copy link
Member

chunyu3 commented Mar 30, 2023

@raych1 For #3, Can you share your env? I cannot reproduce locally. Thanks

@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. and removed MQ This issue is part of a "milestone of quality" initiative. labels Mar 30, 2023
@raych1
Copy link
Member Author

raych1 commented Apr 3, 2023

Added another PR for the doc update.
Azure/azure-sdk-tools#5888

@raych1
Copy link
Member Author

raych1 commented Apr 14, 2023

@raych1 For #3, Can you share your env? I cannot reproduce locally. Thanks

I synced with Crystal and fixed issue #3 locally which was caused by mis-configure the path as absolute path in tsplocation.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Docs DPG
Projects
None yet
Development

No branches or pull requests

3 participants