Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [FEATURE REQUEST] Allowing option to specify the MaxDequeueCount to Queues underlying in Blobs #34269

Closed
amnguye opened this issue Feb 16, 2023 · 4 comments · Fixed by #37836
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)

Comments

@amnguye
Copy link
Member

amnguye commented Feb 16, 2023

Library name and version

Microsoft.Azure.WebJobs.Extensions.Storage.Blobs

Query/Question

Related to #33672

For poison blobs when blob trigger fails it retries 5 times by default.
https://learn.microsoft.com/en-us/azure/azure-functions/functions-bindings-storage-blob-trigger?tabs=in-process&pivots=programming-language-csharp#poison-blobs

However in v4 when the packages were shipped together, customers were able to specify the MaxDequeueCount in order to specify the retry amount before the message is added to the blob trigger poison.

Since starting v5, the host.json only applies to queue triggers, and not blob triggers the following properties (including MaxDequeueCount have not been carried forward.

https://learn.microsoft.com/en-us/azure/azure-functions/functions-bindings-storage-queue?tabs=in-process%2Cextensionv5%2Cextensionv3&pivots=programming-language-csharp#host-json

We need to figure out a way to expose this value without using the queues trigger settings.

Environment

No response

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 16, 2023
@amnguye amnguye self-assigned this Feb 16, 2023
@amnguye amnguye added Storage Storage Service (Queues, Blobs, Files) Web Apps labels Feb 16, 2023
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 16, 2023
@amnguye amnguye added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. bug This issue requires a change to an existing behavior in the product in order to be resolved. feature-request This issue requires a new behavior in the product in order be resolved. and removed Web Apps labels Feb 16, 2023
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 16, 2023
@amnguye amnguye added the Client This issue points to a problem in the data-plane of the library. label Feb 16, 2023
@liliankasem
Copy link
Member

If this public doc is up to date, it looks like for v5.x there are host.json settings for blobs: https://learn.microsoft.com/en-us/azure/azure-functions/functions-bindings-storage-blob?tabs=in-process%2Cextensionv5%2Cextensionv3&pivots=programming-language-csharp#hostjson-settings

We could use that to add MaxDequeueCount and other properties?

Or is issue suggesting there is a bug with the host and/or extension where the existing blob config isn't being applied?

@amnguye
Copy link
Member Author

amnguye commented Jul 25, 2023

@liliankasem I left the issue open ended for us to decide how we wanted to resolve the issue.

I think the best way is to add the MaxDequeueCount to the host.json settings for blobs

@liliankasem
Copy link
Member

@liliankasem I left the issue open ended for us to decide how we wanted to resolve the issue.

I think the best way is to add the MaxDequeueCount to the host.json settings for blobs

Yup, I agree. I responded in the email thread about this

You’ll need to update BlobsOptions to add a property for ‘MaxDequeueCount’ and utilize that in the extension as necessary. Any property defined in your options would automatically be exposed in host.json under the extension name.

If this is not working, let us know and we can help investigate if the right configuration pattern is being used.

@amnguye
Copy link
Member Author

amnguye commented Jul 25, 2023

@liliankasem Just made the PR. If someone from your team could review it that would be great.

#37836

I will also get someone from my team to review it as well.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants