Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Higher dependency in SDK than PowerShell #25824

Closed
chidozieononiwu opened this issue Dec 9, 2021 · 2 comments
Closed

[BUG]Higher dependency in SDK than PowerShell #25824

chidozieononiwu opened this issue Dec 9, 2021 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. Monitor - Exporter Monitor OpenTelemetry Exporter Monitor Monitor, Monitor Ingestion, Monitor Query

Comments

@chidozieononiwu
Copy link
Member

chidozieononiwu commented Dec 9, 2021

Library name and version

Azure.Monitor.OpenTelemetry.Exporter

Describe the bug

Azure.Monitor.OpenTelemetry.Exporter pull in System.Diagnostics.DiagnosticSource : 5.0.* as a transitive dependency which is higher than the version in PowerShell 4.0.*

Graph
Azure.Monitor.OpenTelemetry.ExporterOpenTelemetry : 1.1.0OpenTelemetry.Api : 1.1.0System.Diagnostics.DiagnosticSource >= 5.0.1

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1237993&view=logs&j=d41e9505-d81b-5b3c-5b50-be71bc9b0ccb&t=1d797300-f2df-5c9f-af88-b93a037bfad7

Expected behavior

SDKs should not have dependencies higher than those in powershell.

Actual behavior

Azure.Monitor.OpenTelemetry.Exporter pull in a dependency with version higher than present in powershell.

Reproduction Steps

Run net - agregate-report pipeline after removing Azure.Monitor.OpenTelemetry.Exporter from the ignoreList in https://github.com/Azure/azure-sdk-for-net/blob/main/eng/scripts/dependencies/generate-deps.ps1

Environment

No response

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 9, 2021
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Monitor - Exporter Monitor OpenTelemetry Exporter labels Dec 9, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 9, 2021
@scottaddie scottaddie added the Monitor Monitor, Monitor Ingestion, Monitor Query label Jun 15, 2022
@cijothomas
Copy link
Contributor

SDKs should not have dependencies higher than those in powershell.

What is the reason for this?

@reyang
Copy link
Member

reyang commented Feb 21, 2023

Closing as by design.

@chidozieononiwu feel free to reopen if you think the decision is wrong with an explanation why you believe "SDKs should not have dependencies higher than those in powershell".

@reyang reyang closed this as completed Feb 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Monitor - Exporter Monitor OpenTelemetry Exporter Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

No branches or pull requests

5 participants