Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Tests: write tests for parameter validation in models #17650

Closed
kinelski opened this issue Dec 18, 2020 · 1 comment
Closed

[MetricsAdvisor] Tests: write tests for parameter validation in models #17650

kinelski opened this issue Dec 18, 2020 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor test-enhancement
Milestone
Backlog

Comments

@kinelski
Copy link
Member

kinelski commented Dec 18, 2020 •
edited
Loading

Depends on: #16321, as some designs will change.

  • Write tests for models.
  • Write tests for input-only classes as well.
@kinelski kinelski added Test Debt Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Dec 18, 2020
@kinelski kinelski added this to the Backlog milestone Dec 18, 2020
@kinelski kinelski mentioned this issue Dec 18, 2020
Merged
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Mar 12, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

Hi @kinelski. There hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by removing the no-recent-activity label. Otherwise, we'll close this out in 7 days.

@kinelski kinelski removed the no-recent-activity There has been no recent activity on this issue. label Mar 12, 2021
@kinelski kinelski modified the milestones: Backlog, [2021] May Apr 19, 2021
@kinelski kinelski modified the milestones: [2021] May, [2021] June May 7, 2021
@kinelski kinelski modified the milestones: [2021] June, Backlog Jun 10, 2021
@jsquire jsquire added test-reliability Issue that causes tests to be unreliable and removed Test Debt labels Jul 16, 2021
@kinelski kinelski added test-enhancement and removed test-reliability Issue that causes tests to be unreliable labels Aug 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor test-enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jsquire @kinelski @pallavit