Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Consider creating overloads for similar service methods #16319

Closed
kinelski opened this issue Oct 27, 2020 · 0 comments · Fixed by #16503
Closed

[MetricsAdvisor] Consider creating overloads for similar service methods #16319

kinelski opened this issue Oct 27, 2020 · 0 comments · Fixed by #16503
Assignees
@kinelski
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
[2020] November

Comments

@kinelski
Copy link
Member

kinelski commented Oct 27, 2020 •
edited
Loading

  • GetAnomaliesForAlert and GetAnomaliesForDetectionConfiguration could be overloads of the same method: GetAnomalies.
  • GetIncidentsForAlert and GetIncidentsForDetectionConfiguration could be overloads of the same method: GetIncidents.
  • Anything else with the pattern Get<...>For<...>.
@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Oct 27, 2020
@kinelski kinelski added this to the [2020] November milestone Oct 27, 2020
@kinelski kinelski mentioned this issue Oct 27, 2020
Closed
@kinelski kinelski added the blocking-release Blocks release label Oct 30, 2020
@kinelski kinelski mentioned this issue Nov 2, 2020
Merged
@kinelski kinelski self-assigned this Nov 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kinelski kinelski

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
[2020] November
Development

Successfully merging a pull request may close this issue.

[MetricsAdvisor] Made similar service methods overloads kinelski/azure-sdk-for-net
1 participant
@kinelski