Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving Statistics from TextAnalyticsResult to atomic types #11717

Closed
annelo-msft opened this issue Apr 30, 2020 · 1 comment
Closed

Consider moving Statistics from TextAnalyticsResult to atomic types #11717

annelo-msft opened this issue Apr 30, 2020 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics Cognitive Services
Milestone
[2020] May

Comments

@annelo-msft
Copy link
Member

If we adopt the current Warnings proposal, we'll be putting document-level warnings on the atomic types, so that they come back in the single-input methods. Consider moving Statistics to the atomic types as well, so that they'll be accessible from single-input methods as well. We may decided this doesn't make sense.
@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Cognitive Services TextAnalytics labels Apr 30, 2020
@annelo-msft annelo-msft added this to the [2020] May milestone Apr 30, 2020
@maririos
Copy link
Member

maririos commented May 6, 2020

The problem with adding statistics here, i that for single operations we don't have a way to set IncludeStatistics= true as we don't pass TextAnalyticsRequestOptions to them for simplicity

@maririos maririos closed this as completed May 6, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Nov 19, 2020
CodeGen from PR 11717 in Azure/azure-rest-api-specs
65b5e30 
Specifying shipping address required property to autorest. (Azure#11717)

* Ensuring autorest generation follow specific order of required properties in shippingAddress

* added details  sharp yaml
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics Cognitive Services
Projects
None yet
Milestone
[2020] May
Development

No branches or pull requests
2 participants
@maririos @annelo-msft