Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mangement plane PR triggers data-plane CI #11640

Closed
isra-fel opened this issue Apr 28, 2020 · 2 comments
Closed

Mangement plane PR triggers data-plane CI #11640

isra-fel opened this issue Apr 28, 2020 · 2 comments
Assignees
Labels
Mgmt-EngSys Engineering System (Management Plane Specific)

Comments

@isra-fel
Copy link
Member

What I see

Mgmt-plane-only PR triggers data-plane CI, for example #11625 , so if there's error in data-plane, the pr is blocked (check-enforcer demands all CI to pass).

Question

I think in general the failure of data-plane CI should not block mgmt-plane PRs, but I want to here your voice.

Proposed solution

  1. The reviewer tells check enforcer it's OK to ignore the failed data-plane checks
  2. Update data-plane CI to exclude mgmt-plane projects

cc @weshaggard @mitchdenny @erich-wang @chidozieononiwu

@isra-fel isra-fel added Mgmt-EngSys Engineering System (Management Plane Specific) EngSys This issue is impacting the engineering system. labels Apr 28, 2020
@isra-fel isra-fel self-assigned this Apr 28, 2020
@weshaggard
Copy link
Member

cc @allenjzhang

This is being triggered because we don't limit the path filtering to just the data-plane library at https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/containerregistry/ci.yml#L22.

We have a couple options here:

  1. We could update our script https://github.com/Azure/azure-sdk-for-net/blob/master/eng/scripts/Update-Mgmt-Yml.ps1 which correctly sets up the mgmt path filters to also update the path filters in the ci.yml files as well.
  2. We could simply let them continue to trigger and if they are failing for other reasons ignore the failures and proceed with check-in.
  3. We could work to ensure both mgmt and data-plane stay clean and always passing.

I was chatting with @allenjzhang about the track 2 mgmt libraries and for those I would like to go with option 3. However for the existing track 1 mgmt libraries perhaps we can go with option 1. It shouldn't be too hard to alter that script to adjust all these.

@kurtzeborn kurtzeborn removed the EngSys This issue is impacting the engineering system. label Apr 28, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Nov 17, 2020
add traceLevel, continueOnError, and runConcurrently properties to Dataflow activity properties (Azure#11640)
@jsquire
Copy link
Member

jsquire commented Dec 14, 2022

This issue is fairly stale by now and the T1 packages are deprecated with T2 reaching GA. I'm going to close this out and we can address any specific cases on an as-needed basis.

@jsquire jsquire closed this as completed Dec 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Mgmt-EngSys Engineering System (Management Plane Specific)
Projects
None yet
Development

No branches or pull requests

4 participants