Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service-bus] Improve doc strings for create() methods on ServiceBusClient #8778

Conversation

richardpark-msft
Copy link
Member

@richardpark-msft richardpark-msft commented May 7, 2020

Simple improvements for the doc strings when describing the receiveMode for create*() methods in ServiceBusClient

Also corrected an inaccuracy on the dead letter documentaion. You can't dead letter a dead lettered message!
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for #8778 (comment) to be addressed before approving...

Otherwise, rest looks great

@richardpark-msft richardpark-msft merged commit 373e27f into Azure:master May 11, 2020
@richardpark-msft richardpark-msft deleted the richardpark-sb-track2-fix-docstrings branch May 11, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants