Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recorder] Add logging #21641

Merged
merged 12 commits into from
Jun 3, 2022
Merged

[Recorder] Add logging #21641

merged 12 commits into from
Jun 3, 2022

Conversation

timovv
Copy link
Member

@timovv timovv commented Apr 27, 2022

Packages impacted by this PR

  • @azure-tools/test-recorder

Issues associated with this PR

Describe the problem that is addressed by this PR

Adds logging to the recorder to aid in debugging.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Nope, this PR doesn't change any behavior.

Checklists

  • Added a changelog (if necessary)

@timovv timovv marked this pull request as draft April 27, 2022 18:00
@timovv timovv marked this pull request as ready for review April 27, 2022 20:21
@azure-sdk
Copy link
Collaborator

API change check for @azure/container-registry

API changes are not detected in this pull request for @azure/container-registry

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@HarshaNalluru
Copy link
Member

Looks good, we can always add more as needed based on the debug sessions or new features, let's merge now.

@timovv timovv merged commit f04cc7d into Azure:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recorder] Add logging - with azure logger
3 participants