Clean up entries in docsettings.yml #15146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run js - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
commented
Jun 7, 2021
ramya-rao-a
commented
Jun 7, 2021
ramya-rao-a
force-pushed
the
doc-settings-cleanup
branch
from
ff4cefe to
cc59e80
Compare
chidozieononiwu
requested changes
Jun 7, 2021
ramya-rao-a
requested review from
danieljurek,
mikeharder,
mitchdenny,
praveenkuttappan and
weshaggard
as code owners
chidozieononiwu
approved these changes
Jun 7, 2021
|
Hello @ramya-rao-a! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jul 9, 2021
Fix 20210301preview bugs (Azure#15146) * Add Identity to createWorkpace example * change for getTransitivePEUsages * update * prettier code * add another new endpoint * address comments * change for getTransitivePEUsages * update * prettier code * add another new endpoint * address comments * revert change on transitivePE and notebookKeys * revert change on transitivePE and notebookKeys * add new stable version 2021-01-01 * add ListNotebookAccessToken * add primaryUserAssignedIdentity * fix missing properties and apis * fix one more missing property * 202 status for start and stop CI * make resync keys long runnin operation in version Jan2021 * resync keys 204 * update resync keys example * Dont throw 204 for resync * update resync keys * Formatting * revert Jan2021changes and add new version * start apr2021 version for azure ml rp * undo remove new line in jan2021 * use systemData definition in common * removed old files * fix small swagger bugs * run prettier * remove reference to sku * update readme * minimum agentCount should be 0 * add createdOn and ModifiedOn to compute properties * add LoadBalancerType to aks compute * add isNotebookInstanceCompute to virtualMachine * add leafDomainLabel to SslConfiguration * add overwriteExistingDomain to SslConfiguration * add synapseSpark as supported compute-type * update patch compute response to 202 * remove location from example responses * Revert "remove location from example responses" This reverts commit 048bf2551513afae842a9c4fbb5861aeddc6c33a. * MachineLearningCompute_Update should have a 200 response * sys data to use local def due to naming conflicts. * Fix enum casing * Fix operationId PR comment. * Change opId in apr version * remove 20210401 for easy review * only change api version * merge changes for 20210401 version * Add x-ms-discriminator-value for Synapse spark * camelcase loadbalancer properties * add createdOn and Modified on to examples * address AvoidAnonymousTypes error for SynapseSpark * Minor fixes + new property * Remove subscription state. * fix bug Co-authored-by: Vinay Rajmal Soni <[email protected]> Co-authored-by: Suba <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Josh Peterson <[email protected]> Co-authored-by: Suba <[email protected]>
ramya-rao-a
added a commit
that referenced
this pull request
Aug 11, 2021
Looks it was I who added `sdk/*README` in #15146, but I cannot recall the reason. Other entries were for cases that we genuinely did need to skip
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect the readme files in each of the packages to follow a particular template.
The docsettings.yml file is where we have added exceptions for this rule.
The
omitted_pathsis for those readmes that intentionally do not follow this ruleThe
known_content_issuesis for those readmes that we believe should follow the rule and so there is a tracking issue to update itThe
known_presence_issuesis for those readmes that dont exist but shouldThis PR cleans up this file as follows: