[core-rest-pipeline] Add opt-in HTTP support #14316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new option to allow insecure connections and support calling HTTP URLs.
xirzec
added
Client
deyaaeldeen
approved these changes
Mar 17, 2021
Comment on lines
69
to
70
| private httpsKeepAliveAgent?: http.Agent; | ||
| private httpsProxyAgent?: http.Agent; |
There was a problem hiding this comment.
should not those types come from https?
Suggested change
| private httpsKeepAliveAgent?: http.Agent; | |
| private httpsProxyAgent?: http.Agent; | |
| private httpsKeepAliveAgent?: https.Agent; | |
| private httpsProxyAgent?: https.Agent; |
sarangan12
approved these changes
Mar 17, 2021
jeremymeng
approved these changes
Mar 17, 2021
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
Add new option to allow insecure connections and support calling HTTP URLs.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
May 21, 2021
[Hub Generated] Review request for Microsoft.Maps to add version preview/2021-07-01-preview (Azure#14316) * Adds base for updating Microsoft.Maps from version stable/2021-02-01 to version 2021-07-01-preview * Updates readme * Updates API version in new specs and examples * managed identities * updates based on design review * fixes for examples * adding description * updated example request responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new option to allow insecure connections and support calling HTTP URLs, including calling through proxies.
This also adds security checks in the browser version for parity.