Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-auth] shouldn't export OperationOptions #8301

Closed
xirzec opened this issue Apr 9, 2020 · 3 comments · Fixed by #8410
Closed

[core-auth] shouldn't export OperationOptions #8301

xirzec opened this issue Apr 9, 2020 · 3 comments · Fixed by #8410
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@xirzec
Copy link
Member

xirzec commented Apr 9, 2020

In #5899 we ended up exporting an interface called "OperationOptions" that isn't exactly the same as the one in core-http, but structurally compatible.

This can create a big of confusion, so for now we should stop exporting this interface and inline all necessary options to GetTokenOptions until we can put the real OperationOptions in a common place.

/cc @daviwil @bterlson @ramya-rao-a

@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Apr 9, 2020
@xirzec xirzec added this to the Backlog milestone Apr 9, 2020
@ramya-rao-a
Copy link
Contributor

As library authors when we use OperationOptions, auto-complete now gives suggestions from both core-auth and core-http, so we may end up with a mix and match of these.

I agree with @xirzec that we should inline these in core-auth and have a single source of truth for exported interfaces

@daviwil
Copy link
Contributor

daviwil commented Apr 17, 2020

Thanks @ramya-rao-a for reminding me to respond to this. Yes, it was a mistake to add another OperationOptions to core-auth, I'm totally on board with removing it and inlining the necessary fields. We'd have to bump the major version of core-auth, but since users shouldn't be depending on this directly it hopefully won't be a problem.

@bterlson
Copy link
Member

I think the odds of someone depending on this type by name are so low that we can just consider this a bug fix.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants