Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup: replace config is wrong #7243

Closed
xirzec opened this issue Feb 4, 2020 · 1 comment · Fixed by #8909
Closed

Rollup: replace config is wrong #7243

xirzec opened this issue Feb 4, 2020 · 1 comment · Fixed by #8909
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@xirzec
Copy link
Member

xirzec commented Feb 4, 2020

Per https://github.com/rollup/plugins/tree/master/packages/replace

Our replace config should look like

    replace({
        delimiters: ["", ""],
        // replace dynamic checks with if (true) since this is for node only.
        // Allows rollup's dead code elimination to be more aggressive.
        "if (isNode)": "if (true)"
      }),

instead of

   replace({
        delimiters: ["", ""],
        values: {
          // replace dynamic checks with if (true) since this is for node only.
          // Allows rollup's dead code elimination to be more aggressive.
          "if (isNode)": "if (true)"
        }
      }),

Which doesn't replace anything anymore. Not sure if this changed since a previous plugin version, but tested it on core-http.

Not a big deal since we're not shipping browser bundles, but still seems like it should be cleaned up.

@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Feb 4, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] March milestone Feb 5, 2020
@xirzec xirzec modified the milestones: [2020] March, Backlog Mar 9, 2020
@jeremymeng
Copy link
Member

Fixed in #8909

@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants