Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] Remove circular dependencies #4614

Closed
chradek opened this issue Aug 1, 2019 · 0 comments · Fixed by #7000
Closed

[Event Hubs] Remove circular dependencies #4614

chradek opened this issue Aug 1, 2019 · 0 comments · Fixed by #7000
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs

Comments

@chradek
Copy link
Contributor

chradek commented Aug 1, 2019

When running npm build, rollup complains about the following circular dependencies:

(!) Circular dependency: dist-esm/src/eventHubClient.js -> dist-esm/src/connectionContext.js -> dist-esm/src/managementClient.js -> dist-esm/src/eventHubClient.js
(!) Circular dependency: dist-esm/src/eventHubClient.js -> dist-esm/src/sender.js -> dist-esm/src/eventHubSender.js -> dist-esm/src/eventHubClient.js
(!) Circular dependency: dist-esm/src/eventProcessor.js -> dist-esm/src/pumpManager.js -> dist-esm/src/eventProcessor.js
(!) Circular dependency: dist-esm/src/eventProcessor.js -> dist-esm/src/pumpManager.js -> dist-esm/src/partitionPump.js -> dist-esm/src/eventProcessor.js

We should update our code where possible to prevent circular dependencies.

@chradek chradek added Client This issue points to a problem in the data-plane of the library. Event Hubs labels Aug 1, 2019
@ramya-rao-a ramya-rao-a added this to the [2020] February milestone Dec 5, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants