Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage browser tests fail when using test-utils-recorder #4409

Closed
mikeharder opened this issue Jul 24, 2019 · 2 comments
Closed

Storage browser tests fail when using test-utils-recorder #4409

mikeharder opened this issue Jul 24, 2019 · 2 comments
Assignees
@HarshaNalluru
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@mikeharder
Copy link
Member

When updating the storage tests to use test-utils-recorder, the Node tests pass but the Browser tests fail with:

Uncaught TypeError: Cannot read property 'setEnviromentOnLoad' of undefined
    at Suite.<anonymous> (index.browser.js:9)
    at Object.create (mocha.js:720)
    at context.describe.context.context (mocha.js:532)
    at index.browser.js:9
    at index.browser.js:9
    at index.browser.js:9
@mikeharder mikeharder added the EngSys This issue is impacting the engineering system. label Jul 24, 2019
@mikeharder
Copy link
Member Author

Partial fix at https://github.com/mikeharder/azure-sdk-for-js/commits/TestNewCommonRecorderFixes

@kurtzeborn kurtzeborn added the Storage Storage Service (Queues, Blobs, Files) label Jul 26, 2019
@kurtzeborn kurtzeborn added Client This issue points to a problem in the data-plane of the library. and removed EngSys This issue is impacting the engineering system. labels Aug 12, 2019
@HarshaNalluru
Copy link
Member

This is fixed - HarshaNalluru#15.
@azure/test-utils-recorder is imported by keyvault and the tests are running fine now.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HarshaNalluru HarshaNalluru

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikeharder @HarshaNalluru @kurtzeborn