Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint output to both terminal and file in same command #4344

Closed
KarishmaGhiya opened this issue Jul 17, 2019 · 2 comments
Closed

Eslint output to both terminal and file in same command #4344

KarishmaGhiya opened this issue Jul 17, 2019 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. eslint plugin feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@KarishmaGhiya
Copy link
Member

KarishmaGhiya commented Jul 17, 2019 •
edited
Loading

we should display results to both the console and generate the report in the same command instead of having two separate commands: lint and lint:terminal
https://github.com/lwhiteley/eslint-output
@kurtzeborn kurtzeborn added EngSys This issue is impacting the engineering system. and removed triage labels Jul 17, 2019
@KarishmaGhiya KarishmaGhiya self-assigned this Jul 17, 2019
@ramya-rao-a ramya-rao-a added eslint plugin feature-request This issue requires a new behavior in the product in order be resolved. labels Jul 2, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jul 2, 2020
@ramya-rao-a ramya-rao-a removed the EngSys This issue is impacting the engineering system. label Jul 2, 2020
@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jul 20, 2020
@ramya-rao-a ramya-rao-a mentioned this issue Aug 20, 2020
Merged
@ramya-rao-a
Copy link
Contributor

As discussed offline, a better approach would be to get to a state where we have fixed the linting errors and then run the linter as part of the build step so that build breaks on the introduction of any new linting error.

With that in mind, we should not need the output to both terminal and report.

@ramya-rao-a
Copy link
Contributor

cc @praveenkuttappan, @deyaaeldeen, @sadasant

@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. eslint plugin feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xirzec @KarishmaGhiya @ramya-rao-a @kurtzeborn