Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CHANGELOG and samples to reflect additional type renamings in document intelligence #32327

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

vsantele
Copy link
Contributor

@vsantele vsantele commented Dec 20, 2024

Packages impacted by this PR

@azure-rest/ai-document-intelligence-rest

Issues associated with this PR

#32326

Describe the problem that is addressed by this PR

Some types renamed in version 1.0.0 are not reflected everywhere

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

This PR only change types, there is no test for that as far as I know.

Provide a list of related PRs (if any)

Command used to generate this PR: (Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description.
  • Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
  • Added a changelog (if necessary).

@vsantele vsantele requested review from xirzec and a team as code owners December 20, 2024 18:14
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 20, 2024
Copy link

Thank you for your contribution @vsantele! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@vsantele vsantele changed the title chore: update CHANGELOG to reflect additional type renamings in document intelligence update CHANGELOG and samples to reflect additional type renamings in document intelligence Dec 20, 2024
@vsantele
Copy link
Contributor Author

vsantele commented Jan 5, 2025

Is it possible to get feedback on why this PR is not being reviewed when #32412 is already merged, even though it only fixes part of the problem?

Are there too many changes at once? Do I need to provide a PR for each part, like readme, samples and migration documentation?

It's been two weeks, this package reached GA with a migration guide and samples that contain errors.

I just want to know how to improve potential future PRs.

@HarshaNalluru
Copy link
Member

Thanks @vsantele for the valuable contribution, the changes look good.
The bot has not notified me about this PR or the other one, will look into the bot.

@HarshaNalluru HarshaNalluru merged commit afb01e8 into Azure:main Jan 6, 2025
18 checks passed
@vsantele
Copy link
Contributor Author

vsantele commented Jan 6, 2025

Thank you for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants