-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cosmos] Migrate @azure/cosmos to ESM/vitest #32079
base: main
Are you sure you want to change the base?
Conversation
… feat/cosmos-esm
API change check API changes are not detected in this pull request. |
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good to me! I've added a few comments to help improve understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't see integration tests running for this PR, by any chance did you disable it @mpodwysocki ? |
@topshot99 integration tests do not run as part of PR builds, only via nightly builds |
API change check API changes are not detected in this pull request. |
2 similar comments
API change check API changes are not detected in this pull request. |
API change check API changes are not detected in this pull request. |
… feat/cosmos-esm
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Migrates @azure/cosmos to ESM/vitest via automation.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists