Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmos] Migrate @azure/cosmos to ESM/vitest #32079

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

Conversation

mpodwysocki
Copy link
Member

Packages impacted by this PR

  • @azure/cosmos

Issues associated with this PR

Describe the problem that is addressed by this PR

Migrates @azure/cosmos to ESM/vitest via automation.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@github-actions github-actions bot added the Cosmos label Dec 6, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@topshot99 topshot99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me! I've added a few comments to help improve understanding.

Copy link
Member

@sajeetharan sajeetharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topshot99
Copy link
Member

I don't see integration tests running for this PR, by any chance did you disable it @mpodwysocki ?

@mpodwysocki
Copy link
Member Author

I don't see integration tests running for this PR, by any chance did you disable it @mpodwysocki ?

@topshot99 integration tests do not run as part of PR builds, only via nightly builds

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

2 similar comments
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants