Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@azure/core-rest-pipeline broken for Node.js 14 #28950

Closed
1 task
saravanan-sb opened this issue Mar 18, 2024 · 3 comments
Closed
1 task

@azure/core-rest-pipeline broken for Node.js 14 #28950

saravanan-sb opened this issue Mar 18, 2024 · 3 comments
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@saravanan-sb
Copy link

  • Package Name: @azure/core-rest-pipeline
  • Package Version: 1.9.1
  • Operating system:
  • nodejs
    • version: 14.21.3

Describe the bug
Attempting to import SDK results in an exception caused by syntax that's not supported in node 14:
SyntaxError: Unexpected token '??='

To Reproduce
Steps to reproduce the behavior:
npm i @azure/core-rest-pipeline

To get the following error

`/[...]/node_modules/@azure/core-rest-pipeline/dist/commonjs/policies/multipartPolicy.js:99`
            `boundary ??= parsedBoundary;`
                     `^^^`

`SyntaxError: Unexpected token '??='`

Expected behavior
Since previous version of the package did support node 14, the new version should either stay backwards compatible or be published as a major release.

Additional context
I ended up here by debugging a problem with @azure/web-pubsub which used to work for me until yesterday and now it suddenly broke because of the reason explained above

A possible solution for this would be to publish a patch for @azure/core-rest-pipeline with the syntax reverted to a more compatible version.

@github-actions github-actions bot added Azure.Core Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 18, 2024
Copy link

Copy link

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@maorleger
Copy link
Member

hey @saravanan-sb thanks for reaching out - this looks to be the same issue currently tracked in #28918 - going to close this as dupe to keep conversation in a single thread. Please do review #28918 for suggestions 👍

@maorleger maorleger closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

2 participants