-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opentelemetry-instrumentation-azure-sdk] Adopt OpenTelemetry HTTP semconv 1.23.1 #27585
Comments
@lmolkova hi! Any concerns about breaking changes / should we populate both or just rename the existing attributes? Just wanted to double check 👍 |
cc @hectorhdzg since appInsights uses our tracer - @hectorhdzg any concerns about renaming these attributes or do we need to keep both for backwards compat? |
We did breaking change on .NET and Java - given that plugins are experimental, we can do it. |
@maorleger JS OTel is currently working on supporting new semconv, work is being tracked here, currently exporters do not support latest semantic convention, including Azure Monitor one, I will sync with Java/.NET folks but I suppose they have code to support backward compatibly attributes, so maybe it makes sense to hold this one for a few, until exporters have support for it. |
.NET exporter supports all new semconv attributes https://github.com/Azure/azure-sdk-for-net/blob/fe7a2ec767b968f13c544e1ac902e299d0022639/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/Vendoring/Shared/SemanticConventions.cs#L106 @hectorhdzg is there an issue for @azure/monitor-opentelemetry-exporter we can track to know when it's done? The one you linked is for JS HTTP client instrumentations. |
Update HTTP attributes to comply with HTTP semconv vTBD (likely 1.23.0 will declare them as stable):
http.method
->http.request.method
http.status_code
->http.response.status_code
net.peer.name
->server.address
net.peer.port
->server.port
http.url
->url.full
http.user_agent
->user_agent.original
error.type
- some error-code or a full exception name if exception happens. Also includes status code (as string) for responses we consider to be an error. Maybe we can steal something from .NET - https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Http/src/System/Net/Http/Metrics/MetricsHandler.cs#L157http.request.resend_count
- try countThe text was updated successfully, but these errors were encountered: