Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Recorder] NoOpCredential helper #19387

Closed
timovv opened this issue Dec 16, 2021 · 0 comments · Fixed by #19423
Closed

[Unified Recorder] NoOpCredential helper #19387

timovv opened this issue Dec 16, 2021 · 0 comments · Fixed by #19423
Assignees
@HarshaNalluru
Labels
test-utils-recorder Label for the issues related to the common recorder
Milestone
[2022] January

Comments

@timovv
Copy link
Member

timovv commented Dec 16, 2021

Create a helper that wraps NoOpCredential and ClientSecretCredential (or perhaps AzureDefaultCredential?), automatically selecting NoOpCredential when in playback mode and ClientSecretCredential when in record mode.

This helper needs to be in a separate package to the usual @azure/test-utils package to avoid creating a cyclic dependency with Identity.

We should create an internal @azure/test-utils-identity package for this helper.

Originally posted by @timovv in #18817 (comment)

Cc: @HarshaNalluru @witemple-msft
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 16, 2021
@timovv timovv added the test-utils-recorder Label for the issues related to the common recorder label Dec 16, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 16, 2021
@HarshaNalluru HarshaNalluru added this to the [2022] January milestone Dec 16, 2021
@HarshaNalluru HarshaNalluru self-assigned this Dec 16, 2021
@HarshaNalluru HarshaNalluru mentioned this issue Dec 17, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HarshaNalluru HarshaNalluru

Labels
test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Milestone
[2022] January
Development

Successfully merging a pull request may close this issue.

[Unified Recorder] New test-utils package for test credential HarshaNalluru/azure-sdk-for-js
2 participants
@timovv @HarshaNalluru