Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@azure/abort-controller - 1 more sample? #18292

Closed
diberry opened this issue Oct 20, 2021 · 3 comments
Closed

@azure/abort-controller - 1 more sample? #18292

diberry opened this issue Oct 20, 2021 · 3 comments
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Docs

Comments

@diberry
Copy link
Contributor

diberry commented Oct 20, 2021

The samples for @azure/abort-controller are good but just a touch too abstract. Could there be 1 more sample with a bullet-proof (ish) task like listing resource groups, that could demonstrate the time out functionality?

The timeout operation also makes me wonder, what is the default timeout period for the Azure SDK calls, if the abort signal isn't passed in? Probably doc'd someplace so please include that link if you can.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 20, 2021
@diberry
Copy link
Contributor Author

diberry commented Oct 20, 2021

Once more question - is the ref docs supposed to have methods, properties, etc? It just shows the readme-seems to be missing the TOC.

image

@ramya-rao-a
Copy link
Contributor

Thanks for reporting @diberry

For the issue in your second comment, I have logged #18320

Regarding more samples, how about linking to the blog post we wrote on this topic? See How to use abort signals to cancel operations in the Azure SDK for JavaScript/TypeScript

@ramya-rao-a ramya-rao-a added Azure.Core Client This issue points to a problem in the data-plane of the library. Docs labels Oct 22, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 22, 2021
Copy link

Hi @diberry, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Docs
Projects
None yet
Development

No branches or pull requests

2 participants