Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node doesn't support some of the samples for smoke test #17951

Closed
11 tasks done
ckairen opened this issue Sep 29, 2021 · 4 comments
Closed
11 tasks done

Node doesn't support some of the samples for smoke test #17951

ckairen opened this issue Sep 29, 2021 · 4 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Docs Search

Comments

@ckairen
Copy link
Member

ckairen commented Sep 29, 2021

The samples files -

  • appconfiguration/app-configuration
    • featureFlag.js
    • secretReference.js
  • communication/communication-sms
    • sendSmsWithOptions.js
  • search/search-documents
    • interfaces.js
    • setup.js

These samples files uses ES6 syntax (export instead of module.export that node supports), and aren't supported by Node. As the result, the smoke tests won't be able to run these samples files. This commit #17791 skips those files for now. Once those samples are modified, please also change the "skip" and "skipFolder" in the package.json.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 29, 2021
@benbp
Copy link
Member

benbp commented Oct 15, 2021

@ramya-rao-a anything you need from us to get this triaged?

@ramya-rao-a ramya-rao-a added App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library. labels Oct 19, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 19, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] November milestone Oct 19, 2021
@ramya-rao-a ramya-rao-a added bug This issue requires a change to an existing behavior in the product in order to be resolved. Docs labels Oct 19, 2021
@ramya-rao-a
Copy link
Contributor

My apologies @ckairen and @benbp, I missed the notification for this issue

@HarshaNalluru, can you please sync with Will and see what can be done here?

@HarshaNalluru
Copy link
Member

I have resolved the issues with app-config and communication at #18362

@sarangan12 can you handle the search-documents part?

@sarangan12
Copy link
Member

The search-documents task has been completed with PR #18496.

As there are no pending action items, I am closing this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Docs Search
Projects
None yet
Development

No branches or pull requests

5 participants