Encryption Api for Bulk Operations #26672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…011/azure-sdk-for-java into users/akataria/EncryptionBulkApi
ghost
added
the
aayush3011
requested review from
FabianMeiswinkel,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
moderakh,
simplynaveen20 and
xinlian12
as code owners
aayush3011
added
the
azure-cosmos-encryption
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Outdated
Show resolved
Hide resolved
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Outdated
Show resolved
Hide resolved
...-cosmos-encryption/src/test/java/com/azure/cosmos/encryption/EncryptionAsyncApiCrudTest.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/batch/BulkExecutor.java
Outdated
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Outdated
Show resolved
Hide resolved
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Outdated
Show resolved
Hide resolved
|
Once all the current comments are resolved and emulator ci run clean, please run the full ci by commenting "/azp run java - cosmos - tests" in the pr. As we have touched the files in Cosmos project , its safe to do that |
aayush3011
changed the title
kushagraThapar
requested changes
Feb 2, 2022
| return cosmosItemOperationMono; | ||
| }); | ||
|
|
||
| final CosmosBulkExecutionOptions cosmosBulkExecutionOptions = bulkOptions; |
There was a problem hiding this comment.
This will not work, because encryptionProcessor is not initialized if the encryption does not happen. Encryption happens only when the above flux gets executed. And this header code will get executed before encryption is happening.
This header needs to be set in the flux chain. Please revert this code to its original state.
...mos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java
Outdated
Show resolved
Hide resolved
aayush3011
requested review from
kushagraThapar
and removed request for
moderakh
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
simplynaveen20
approved these changes
Feb 4, 2022
kushagraThapar
approved these changes
Feb 4, 2022
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Nov 16, 2023
Ericchoi/main/event hub/2024 01 01 (Azure#26672) * Adding new version 2024-01-01 with changes in Clusters.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encryption Api for Bulk Operations