Bump msal4j version & add regional STS support #22536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianghaolu
requested review from
alzimmermsft,
anuchandy,
backwind1233,
chenrujun,
conniey,
danieljurek,
g2vinay,
hemanttanwar,
JimSuplizio,
JonathanGiles,
mitchdenny,
pallavit,
samvaity,
saragluna,
schaabs,
srnagar,
stliu,
YijunXieMS and
yiliuTo
as code owners
ghost
added
Azure.Core
sdk/identity/azure-identity/src/main/java/com/azure/identity/RegionalAuthority.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/RegionalAuthority.java
Show resolved
Hide resolved
...ty/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClientOptions.java
Outdated
Show resolved
Hide resolved
alzimmermsft
approved these changes
Jun 25, 2021
srnagar
reviewed
Jun 29, 2021
| /** | ||
| * Name of Azure AAD regional authority. | ||
| */ | ||
| public static final String PROPERTY_AZURE_REGIONAL_AUTHORITY_NAME = "AZURE_REGIONAL_AUTHORITY_NAME"; |
There was a problem hiding this comment.
@jianghaolu This property is not included in DEFAULT_CONFIGURATIONS array. All other properties are included. Is there a reason we don't want this to be included?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.