Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/servicebus newapi crosstxn datatype from june master branch #22426

Conversation

hemanttanwar
Copy link
Contributor

@hemanttanwar hemanttanwar commented Jun 21, 2021

This PR is for merging following features into main branch for service bus

  1. Supporting AMQP Data Types
  2. Support cross entity transactions
  3. Added support receiving dead-letter queue (DLQ) for 'ServiceBusProcessorClient' and session receiver using 'subQueue'

API View :
core-amqp API View: https://apiview.dev/Assemblies/Review/06064a28f01e460ab065443b6f6e78e7?diffRevisionId=d4e3f00a3e0a4473836a3c27e039c3e1&doc=False&diffOnly=False

Service Bus: https://apiview.dev/Assemblies/Review/6af850ed7eb04843a6897afbe13cdd28?diffRevisionId=7d50e170bcc342778fd235fee3867293&doc=False&diffOnly=False

1, 2 : These API were reviewed by Srikanta and Jonathan.

Planned GA Release Week of 6/22/21

hemanttanwar and others added 19 commits April 5, 2021 10:59
…20317)

* Added API in builder  for "adding max auto lock renew duration in processor client"
…- into feature branch - preparation for April release. (#20356)

* ServiceBus - cross entity transaction  feature  (#19863)

New Feature: Cross entity transaction API
* Adding feature AMQP SEQUENCE/VALUE data type implementation
* SB april beta release updates
@ghost ghost added Azure.Core azure-core Service Bus azure-spring All azure-spring related issues labels Jun 21, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

Copy link
Contributor

@YijunXieMS YijunXieMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to merge to master since this has been reviewed and previewed for a while.

@hemanttanwar
Copy link
Contributor Author

/azp run java - servicebus - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hemanttanwar
Copy link
Contributor Author

/azp run java - servicebus - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hemanttanwar
Copy link
Contributor Author

/azp run java - servicebus - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hemanttanwar
Copy link
Contributor Author

/azp run java - servicebus - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hemanttanwar hemanttanwar merged commit 064db64 into main Jun 23, 2021
@hemanttanwar hemanttanwar deleted the feature/servicebus-newapi-crosstxn-datatype-from-june-master-branch branch June 23, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core azure-spring All azure-spring related issues Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants