Fixed bug where BlobBaseClient.Exists() did not function correctly for blobs encrypted with CPK #22425
Conversation
* swagger generation and hookup regenerated files swagger for listing hooked up generated and handwritten models expanded client API to support new models * testing and fixes expanded test parameters for file listing. swagger transform added. * rerecorded file listing test * more testing also fixed a method name casing * docstrings and samples * checkstyle * reverted primative boolean extended info arg REST api accepts true or an absence of value. Alligning with .NET for now on Boolean vs boolean. * checkpoint * pr feedback * misused variable fix * fixed test * send nothing, not false: include-extended-info other minor fixes rerecorded tests * import cleanup * swagger regeneration and test fixes * API comments extendedInfo boolean => Boolean renamed options class * reidentified samples for options class name change Co-authored-by: jschrepp-MSFT <[email protected]>
# Conflicts: # sdk/storage/azure-storage-blob/CHANGELOG.md # sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/AppendBlobAsyncClient.java # sdk/storage/azure-storage-common/CHANGELOG.md # sdk/storage/azure-storage-common/src/main/java/com/azure/storage/common/implementation/Constants.java # sdk/storage/azure-storage-file-datalake/CHANGELOG.md # sdk/storage/azure-storage-file-share/CHANGELOG.md # sdk/storage/azure-storage-queue/CHANGELOG.md # sdk/storage/azure-storage-queue/src/test/resources/session-records/QueueSASTestsAccountSASCreateDeleteQueue.json
gapra-msft
requested review from
alzimmermsft,
amishra-dev,
jaschrep-msft,
kasobol-msft and
rickle-msft
as code owners
ghost
added
the
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
There was a problem hiding this comment.
Can you update the description with more info on what we're trying to achieve here besides just this API not throwing in a certain context? What customer need are we responding to with this change? If someone doesn't have the CPK, is it acceptable that we relay true back to them? Is the REST service specifically hiding anything from us on this or is it acknowledging that the blob does indeed exist on this response?
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/CPKTest.groovy
Outdated
Show resolved
Hide resolved
…/blob/CPKTest.groovy Co-authored-by: James <[email protected]>
Updated the description |
Not technically a 78 feature but I need the regenerated code.
This PR is to address a scenario when a customer has a blob encrypted with CPK and calls exists without the CPK on the client.
If someone does not have a CPK, it is fine to return back true since the service is not hiding the fact that the blob exists (otherwise it would return 404 like in incorrect SAS or auth scenarios). The service returns an error message saying the blob uses CPK so it cannot return back properties.