Support multiple subscription configuration options #20796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbp
requested review from
danieljurek,
JimSuplizio,
mitchdenny and
weshaggard
as code owners
weshaggard
approved these changes
Apr 19, 2021
|
/check-enforcer override |
benbp
added
the
Central-EngSys
benbp
added a commit
that referenced
this pull request
Apr 28, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Oct 6, 2022
Refactor AMS resourece-manager folder structure (Azure#20796) * Refactor AMS resourece-manager folder structure * Revert "Refactor AMS resourece-manager folder structure" This reverts commit 28ab42c0c0392f8bed78ee3cfe39f18cebab0e0b. * Refactor the folders with the fix for missing Common.json * Revert "Refactor the folders with the fix for missing Common.json" This reverts commit 1ff1bcac70d3d8df7d2cdf03c1ccd31bfe97fe3a. * Fix missing common.json file references * automated refactor based on the scripts * Update the path to common-types file * Revert "Update the path to common-types file" This reverts commit 08da8ef149323443fd9d4be94f133f5b97a927c6. * Revert "automated refactor based on the scripts" This reverts commit 99bbe67da9407690b285a9abe24413ad0767498c. * Re run the scripts with Common.json file path updates and common-types path updates. * Revert "Re run the scripts with Common.json file path updates and common-types path updates." This reverts commit 8f9b743d8732ef62c4ee42283c49d87547b65887. * Re run the scripts with Common.json file path updates and common-types path updates. * Fix circular references * fix a ref path issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables live tests to use multiple subscription configurations per cloud instead of one. Currently there are some services that need to manage their own cloud-specific values in a keyvault they control (e.g. acs, storage), but also need to use some shared values that only Azure SDK engineering systems can have access to, like service principal credentials.
This change takes advantage of a recent update to enable merging multiple subscription configurations together before passing the value to the ARM template deployment job.