Migrated queues to the new generator #18795
Conversation
ghost
added
the
...azure-storage-queue/src/main/java/com/azure/storage/queue/models/QueueServiceProperties.java
Show resolved
Hide resolved
.../src/main/java/com/azure/storage/queue/implementation/models/QueuesGetPropertiesHeaders.java
Outdated
Show resolved
Hide resolved
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gapra-msft
requested review from
alzimmermsft,
amishra-dev,
jaschrep-msft,
kasobol-msft and
rickle-msft
as code owners
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...e/swagger/src/main/java/com/azure/storage/queue/customization/QueueStorageCustomization.java
Outdated
Show resolved
Hide resolved
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
/azp run java - storage - tests |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run java - storage - tests |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| * | ||
| * @return the xMsVersion value. | ||
| */ | ||
| public String getXMsVersion() { |
There was a problem hiding this comment.
Is there a way to change these method names to not have XMs?
There was a problem hiding this comment.
@srnagar and @jianghaolu Is there a setting in the generator where we can fix that?
There was a problem hiding this comment.
For now you will have to use the customization to rename a method.
There was a problem hiding this comment.
It seems like a bug in autorest core. You have x-ms-client-name defined(https://github.com/Azure/azure-rest-api-specs/blob/storage-dataplane-preview/specification/storage/data-plane/Microsoft.QueueStorage/preview/2018-03-28/queue.json#L70) and the autorest core docs actually used this xMsVersion as an example: https://github.com/Azure/autorest/blob/master/docs/extensions/readme.md#x-ms-client-name
There was a problem hiding this comment.
@jianghaolu Should I create an issue un autorest core?
| /** | ||
| * Package containing classes for AzureQueueStorage. | ||
| */ | ||
| /** Package containing classes for AzureQueueStorage. null. */ |
There was a problem hiding this comment.
@jianghaolu @srnagar is the null. a codegen thing?
There was a problem hiding this comment.
Most likely. I don't see any literal "null" in the swagger spec.
| */ | ||
| @Host("{url}") | ||
| @ServiceInterface(name = "AzureQueueStorageMessageIds") | ||
| @ServiceInterface(name = "AzureQueueStorageMes") | ||
| private interface MessageIdsService { |
config readme python (Azure#18795)
No description provided.