Fixed bug where getFileClient and getSubDirectoryClient on DirectoryClient would throw IllegalArgumentException if either resource had special characters. #18542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gapra-msft
commented
Jan 11, 2021
| @@ -173,8 +173,8 @@ public DataLakeFileAsyncClient getFileAsyncClient(String fileName) { | |||
|
|
|||
| return new DataLakeFileAsyncClient(getHttpPipeline(), | |||
| StorageImplUtils.appendToUrlPath(getPathUrl(), Utility.urlEncode(Utility.urlDecode(fileName))).toString(), | |||
| getServiceVersion(), getAccountName(), getFileSystemName(), getObjectPath() + "/" | |||
| + Utility.urlDecode(fileName), blockBlobAsyncClient); | |||
| getServiceVersion(), getAccountName(), getFileSystemName(), Utility.urlEncode(getObjectPath() + "/" | |||
There was a problem hiding this comment.
This constructor expects an encoded path
gapra-msft
requested review from
alzimmermsft,
amishra-dev,
jaschrep-msft,
kasobol-msft and
rickle-msft
as code owners
rickle-msft
reviewed
Jan 11, 2021
| resourcePrefix | subResourcePrefix || _ | ||
| "" | "" || _ | ||
| Utility.urlEncode("%") | "" || _ // Resource has special character | ||
| "" | Utility.urlEncode("%") || _ // Sub resource has special character |
There was a problem hiding this comment.
I think we should check the path against the expected string to ensure the right amount of encoding/decoding is happening
rickle-msft
approved these changes
Jan 11, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Apr 20, 2022
SCVMM public preview API spec (Azure#18542) * add openapi spec for scvmm * lint fixes, spell fixes * typo fix * prettier * force delete query param * removing some deprecated properties * remove additional props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18469