Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Hand Crafted Model Classes #4899

Closed
alzimmermsft opened this issue Aug 8, 2019 · 3 comments · Fixed by #5268
Closed

Review Hand Crafted Model Classes #4899

alzimmermsft opened this issue Aug 8, 2019 · 3 comments · Fixed by #5268
Assignees
@alzimmermsft
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@alzimmermsft
Copy link
Member

Review the model classes that were created by hand to ensure that no important fields are missing, an example of this is BlobProperties missing the ETag field.
@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Aug 8, 2019
@alzimmermsft alzimmermsft self-assigned this Aug 23, 2019
@rickle-msft
Copy link
Contributor

ContainerProperties is missing metadata

@rickle-msft
Copy link
Contributor

BlobProperties is missing etag

@rickle-msft
Copy link
Contributor

Should include constants for any header values not extracted into hand crafted types.

This was referenced Sep 4, 2019
Closed
Merged
@kurtzeborn kurtzeborn mentioned this issue Sep 11, 2019
Closed
19 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alzimmermsft alzimmermsft

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Review Hand Crafted Model Classes alzimmermsft/azure-sdk-for-java
2 participants
@rickle-msft @alzimmermsft