Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Add support for azure-response-timeout context param in all HttpClients that can support this #40009

Closed
srnagar opened this issue May 2, 2024 · 0 comments · Fixed by #42932
Closed

[FEATURE REQ] Add support for azure-response-timeout context param in all HttpClients that can support this #40009

srnagar opened this issue May 2, 2024 · 0 comments · Fixed by #42932
Assignees
@alzimmermsft
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. HttpClient

Comments

@srnagar
Copy link
Member

srnagar commented May 2, 2024

There are scenarios where we need to change the timeout value of a specific request but not for the entire client. In such cases, we use Context to set azure-response-timeout to change the timeout for that request. This, however, is not supported by all clients. Today, this works only with NettyAsyncHttpClient. OkHttpClient doesn't support changing timeout values for individual requests.

We should investigate if this is supported in other HttpClients like VertX and JdkHttpClient.
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 2, 2024
@srnagar srnagar added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core HttpClient clientcore labels May 2, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 2, 2024
@srnagar srnagar added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. and removed clientcore labels May 2, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 2, 2024
@alzimmermsft alzimmermsft mentioned this issue May 2, 2024
Merged
6 tasks
@alzimmermsft alzimmermsft self-assigned this Nov 13, 2024
@alzimmermsft alzimmermsft mentioned this issue Nov 13, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. HttpClient
Projects
Java SDKs Azure Core
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support per-call timeout in JdkHttpClient alzimmermsft/azure-sdk-for-java
2 participants
@alzimmermsft @srnagar