Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUERY] Does iterableByPage enable for all resource provider? #29640

Closed
2 tasks
chuckz1321 opened this issue Jun 24, 2022 · 5 comments
Closed
2 tasks

[QUERY] Does iterableByPage enable for all resource provider? #29640

chuckz1321 opened this issue Jun 24, 2022 · 5 comments
Assignees
Labels
ARM customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@chuckz1321
Copy link

Query/Question
A clear and concise ask/query.
Does iterableByPage support AzureResourceManager.virtualMachineImages().listByRegion() ?

Why is this not a Bug or a feature Request?
A clear explanation of why is this not a bug or a feature request?
iterableByPage() returns all entities...
image

Setup (please complete the following information if applicable):

  • OS: [e.g. iOS] Windows
  • IDE: [e.g. IntelliJ] InterlliJ
  • Library/Libraries: [e.g. com.azure:azure-core:1.16.0 (groupId:artifactId:version)] azure-resourcemanager 2.10.0

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Query Added
  • Setup information Added use this SDK in Mooncake
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 24, 2022
@joshfree joshfree added ARM Mgmt This issue is related to a management-plane library. labels Jun 28, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 28, 2022
@joshfree
Copy link
Member

Hi @chuckz1321 thanks for reaching out to us via this GitHub issue. @weidongxu-microsoft could you please follow up with @chuckz1321?

@weidongxu-microsoft
Copy link
Member

@chuckz1321

This API is an exception. There is no REST API to list images by region. It had to be done cascaded, list by offer, list by sku on offer, list by image on sku.
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/implementation/VirtualMachineImagesImpl.java#L85-L98

We currently have no good solution to make this nested API call truly pageable.
You may call following API (but then need to iterate again on different sku and offer)

        azure
            .virtualMachines()
            .manager()
            .serviceClient()
            .getVirtualMachineImages()
            .listWithResponse(...);

link #19494

@chuckz1321
Copy link
Author

@weidongxu-microsoft Thanks for you help! Actually we were facing the issue that the query may take longer time and each images will interactive with management endpoint, so that the netty thread will block and finally throw an exception saying the queue is not enough to hold more requests. I configured the netty connection provider and mitigted this issue. (Simply enlarge the timeout parameter...)

@XiaofeiCao XiaofeiCao added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Apr 10, 2023
@ghost
Copy link

ghost commented Apr 10, 2023

Hi @chuckz1321. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@github-actions
Copy link

Hi @chuckz1321, since you haven’t asked that we /unresolve the issue, we’ll close this out. If you believe further discussion is needed, please add a comment /unresolve to reopen the issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ARM customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

4 participants